kallithea Changeset - ba3bdd16ca2d

Changeset - ba3bdd16ca2d

Parent rev.

Child rev.

[Not reviewed]

default

0 1 0

Mads Kiilerich - 10 years ago 2016-03-01 00:16:38
madski@unity3d.com

db: make return type for get_comments consistent - don't return a list for the empty case

1 file changed with 1 insertions and 1 deletions:

kallithea/model/db.py

0 comments (0 inline, 0 general)

kallithea/model/db.py

➞

Show inline comments

@@ @@ -1388,7 +1388,7 @@ class Repository(Base, BaseModel): @@
             .filter(ChangesetComment.repo == self)
         if revisions is not None:
             if not revisions:
-                return [] # don't use sql 'in' on empty set
+                return {} # don't use sql 'in' on empty set
             cmts = cmts.filter(ChangesetComment.revision.in_(revisions))
         grouped = collections.defaultdict(list)
         for cmt in cmts.all():

0 comments (0 inline, 0 general)