kallithea Changeset - bd8ef7119688

Changeset - bd8ef7119688

Parent rev.

Child rev.

[Not reviewed]

beta

0 1 0

Dan Sheridan - 13 years ago 2012-12-18 17:47:35
djs@adelard.com

Recreate the pull request URL each time a checkbox is checked

1 file changed with 2 insertions and 1 deletions:

rhodecode/templates/changelog/changelog.html

0 comments (0 inline, 0 general)

rhodecode/templates/changelog/changelog.html

➞

Show inline comments

@@ @@ -146,12 +146,13 @@ ${_('%s Changelog') % c.repo_name} - ${c @@
 				YAHOO.util.Event.onDOMReady(function(){
                     //Monitor range checkboxes and build a link to changesets
                     //ranges
                     var checkboxes = YUD.getElementsByClassName('changeset_range');
                     var url_tmpl = "${h.url('changeset_home',repo_name=c.repo_name,revision='__REVRANGE__')}";
                     var pr_tmpl = "${h.url('pullrequest_home',repo_name=c.repo_name)}";
                     YUE.on(checkboxes,'click',function(e){
                     	var clicked_cb = e.currentTarget;
                         var checked_checkboxes = [];
                         for (pos in checkboxes){
                             if(checkboxes[pos].checked){
                                 checked_checkboxes.push(checkboxes[pos]);
@@ @@ -200,13 +201,13 @@ ${_('%s Changelog') % c.repo_name} - ${c @@
                             link = link.replace('__E',rev_end.substr(0,6));
                             YUD.get('rev_range_container').href = url;
                             YUD.get('rev_range_container').innerHTML = link;
                             YUD.setStyle('rev_range_container','display','');
                             YUD.setStyle('rev_range_clear','display','');
-                            YUD.get('open_new_pr').href += '?rev_start={0}&rev_end={1}'.format(rev_start,rev_end);
+                            YUD.get('open_new_pr').href = pr_tmpl + '?rev_start={0}&rev_end={1}'.format(rev_start,rev_end);
+                        }
                         else{
                         	YUD.setStyle('rev_range_container','display','none');
                         	YUD.setStyle('rev_range_clear','display','none');
+                        }

0 comments (0 inline, 0 general)