kallithea Changeset - c5f49ffbd72b

Changeset - c5f49ffbd72b

Parent rev.

Child rev.

[Not reviewed]

default

0 2 0

Mads Kiilerich - 12 years ago 2013-12-10 19:30:37
madski@unity3d.com

pullrequests: don't add repo owner as reviewer in all PRs

2 files changed with 0 insertions and 24 deletions:

kallithea/controllers/pullrequests.py

kallithea/templates/pullrequests/pullrequest.html

0 comments (0 inline, 0 general)

kallithea/controllers/pullrequests.py

➞

Show inline comments

@@ @@ -292,18 +292,12 @@ class PullrequestsController(BaseRepoCon @@
         repo = RepoModel()._get_repo(repo_name)
         refs, selected_ref = self._get_repo_refs(repo.scm_instance)
         return {
             'description': repo.description.split('\n', 1)[0],
             'selected_ref': selected_ref,
             'refs': refs,
             'user': dict(user_id=repo.user.user_id,
                          username=repo.user.username,
                          firstname=repo.user.firstname,
                          lastname=repo.user.lastname,
                          gravatar_link=h.gravatar_url(repo.user.email, 28),
                          gravatar_size=14),
+            }
     @LoginRequired()
     @NotAnonymous()
     @HasRepoPermissionAnyDecorator('repository.read', 'repository.write',
                                    'repository.admin')

kallithea/templates/pullrequests/pullrequest.html

➞

Show inline comments

@@ @@ -96,24 +96,12 @@ ${self.repo_context_bar('showpullrequest @@
         <div style="float:left; border-left:1px dashed #eee">
             <div class="pr-details-title">${_('Pull Request Reviewers')}</div>
             <div id="reviewers" style="padding:0px 0px 0px 15px">
               ## members goes here !
               <div>
                 <ul id="review_members" class="group_members">
                 %for member in [c.a_repo.user]:
                   <li id="reviewer_${member.user_id}">
                     <div class="reviewers_member">
                       <div class="gravatar">${h.gravatar(member.email, 14)}</div>
                       <div style="float:left">${member.firstname} ${member.lastname} (${_('owner')})</div>
                       <input type="hidden" value="${member.user_id}" name="review_members" />
                       <span class="action_button" style="padding: 3px" onclick="removeReviewMember(${member.user_id})" title="${_('Remove reviewer')}">
                           <i class="icon-minus-circled"></i>
                       </span>
                     </div>
                   </li>
                 %endfor
                 </ul>
               </div>
               <div class='ac'>
                 <div class="reviewer_ac">
                    ${h.text('user', class_='yui-ac-input',placeholder=_('Type name of reviewer to add'))}
@@ @@ -172,18 +160,12 @@ ${self.repo_context_bar('showpullrequest @@
                   $optgroup.append($('<option/>').text(options[j][1]).val(options[j][0]));
+                }
                 $other_ref.append($optgroup);
+              }
               $other_ref.val(data.selected_ref);
               // reset && add the reviewer based on selected repo
               $('#review_members').html('');
               addReviewMember(data.user.user_id, data.user.firstname,
                               data.user.lastname, data.user.username,
                               data.user.gravatar_link, data.user_gravatar_size);
               // re-populate the select2 thingie
               $("#other_ref").select2({
                   dropdownAutoWidth: true
               });
               $other_ref.prop('disabled', false);

0 comments (0 inline, 0 general)