kallithea Changeset - d04243e932cc

Changeset - d04243e932cc

Parent rev.

Child rev.

[Not reviewed]

beta

0 3 0

Marcin Kuzminski - 13 years ago 2012-06-25 22:40:04
marcin@python-works.com

Added filtering on inbox by comments

3 files changed with 12 insertions and 14 deletions:

rhodecode/controllers/admin/notifications.py

rhodecode/model/notification.py

rhodecode/templates/admin/notifications/notifications.html

0 comments (0 inline, 0 general)

rhodecode/controllers/admin/notifications.py

➞

Show inline comments

@@ @@ -61,10 +61,12 @@ class NotificationsController(BaseContro @@
         # url('notifications')
         c.user = self.rhodecode_user
         notif = NotificationModel().get_for_user(self.rhodecode_user.user_id,
-                                                 filter_=request.GET)
+                                            filter_=request.GET.getall('type'))
         p = int(request.params.get('page', 1))
         c.notifications = Page(notif, page=p, items_per_page=10)
         c.pull_request_type = Notification.TYPE_PULL_REQUEST
         c.comment_type = [Notification.TYPE_CHANGESET_COMMENT,
                           Notification.TYPE_PULL_REQUEST_COMMENT]
         return render('admin/notifications/notifications.html')
     def mark_all_read(self):
@@ @@ -72,11 +74,11 @@ class NotificationsController(BaseContro @@
             nm = NotificationModel()
             # mark all read
             nm.mark_all_read_for_user(self.rhodecode_user.user_id,
                                       filter_=request.GET)
+                                      filter_=request.GET.getall('type'))
             Session.commit()
             c.user = self.rhodecode_user
             notif = nm.get_for_user(self.rhodecode_user.user_id,
                                     filter_=request.GET)
+                                    filter_=request.GET.getall('type'))
             c.notifications = Page(notif, page=1, items_per_page=10)
             return render('admin/notifications/notifications_data.html')

rhodecode/model/notification.py

➞

Show inline comments

@@ @@ -27,7 +27,6 @@ @@
 import os
 import logging
 import traceback
 import datetime
 from pylons.i18n.translation import _
@@ @@ -35,7 +34,6 @@ import rhodecode @@
 from rhodecode.lib import helpers as h
 from rhodecode.model import BaseModel
 from rhodecode.model.db import Notification, User, UserNotification
 from sqlalchemy.orm import joinedload
 log = logging.getLogger(__name__)
@@ @@ -152,7 +150,7 @@ class NotificationModel(BaseModel): @@
                                  Notification.notification_id))
         if filter_:
-            q = q.filter(Notification.type_ == filter_.get('type'))
+            q = q.filter(Notification.type_.in_(filter_))
         return q.all()
@@ @@ -164,7 +162,7 @@ class NotificationModel(BaseModel): @@
             .join((Notification, UserNotification.notification_id ==
                                  Notification.notification_id))
         if filter_:
-            q = q.filter(Notification.type_ == filter_.get('type'))
+            q = q.filter(Notification.type_.in_(filter_))
         # this is a little inefficient but sqlalchemy doesn't support
         # update on joined tables :(

rhodecode/templates/admin/notifications/notifications.html

➞

Show inline comments

@@ @@ -24,15 +24,17 @@ @@
         ##    </li>
         ##</ul>
     </div>
-    %if c.notifications:
       <div style="padding:14px 18px;text-align: right;float:left">
       <span id='all' class="ui-btn"><a href="${h.url.current()}">${_('All')}</a></span>
       <span id='pull_request' class="ui-btn"><a href="${h.url.current(type=c.comment_type)}">${_('Comments')}</a></span>
       <span id='pull_request' class="ui-btn"><a href="${h.url.current(type=c.pull_request_type)}">${_('Pull requests')}</a></span>
       </div>
       %if c.notifications:
       <div style="padding:14px 18px;text-align: right;float:right">
       <span id='mark_all_read' class="ui-btn">${_('Mark all read')}</span>
       </div>
     %endif
+      %endif
   <div id='notification_data'>
     <%include file='notifications_data.html'/>
   </div>
@@ @@ -44,12 +46,8 @@ YUE.on(YUQ('.delete-notification'),'clic @@
  deleteNotification(url_del,notification_id)
 })
 YUE.on('mark_all_read','click',function(e){
     var url = "${h.url('notifications_mark_all_read', **request.GET)}";
+    var url = "${h.url('notifications_mark_all_read', **request.GET.mixed())}";
     ypjax(url,'notification_data',function(){
     	var notification_counter = YUD.get('notification_counter');
     	if(notification_counter){
     		notification_counter.innerHTML=0;
+    	}
     	YUE.on(YUQ('.delete-notification'),'click',function(e){
     		 var notification_id = e.currentTarget.id;
     		 deleteNotification(url_del,notification_id)

0 comments (0 inline, 0 general)