kallithea Changeset - d3e5c259fe71

Changeset - d3e5c259fe71

Parent rev.

Child rev.

[Not reviewed]

beta

0 1 0

Marcin Kuzminski - 13 years ago 2012-09-03 18:21:42
marcin@python-works.com

Fixing inline comment for IE.

1 file changed with 5 insertions and 8 deletions:

rhodecode/public/js/rhodecode.js

0 comments (0 inline, 0 general)

rhodecode/public/js/rhodecode.js

➞

Show inline comments

@@ @@ -364,36 +364,35 @@ var q_filter = function(target,nodes,dis @@
+       }
 	   // if repo_count is set update the number
 	   var cnt = YUD.get('repo_count');
 	   if(cnt){
 		   YUD.get('repo_count').innerHTML = showing;
+	   }
+	}
 };
 var tableTr = function(cls, body){
 	var _el = document.createElement('table');
 	var _el = document.createElement('div');
 	var cont = new YAHOO.util.Element(body);
 	var comment_id = fromHTML(body).children[0].id.split('comment-')[1];
 	var id = 'comment-tr-{0}'.format(comment_id);
 	var _html = ('tbody><tr id="{0}" class="{1}">'+
+	var _html = ('<table><tbody><tr id="{0}" class="{1}">'+
 	              '<td class="lineno-inline new-inline"></td>'+
     			  '<td class="lineno-inline old-inline"></td>'+
                   '<td>{2}</td>'+
                  '</tr>').format(id, cls, body);
+                 '</tr></tbody></table>').format(id, cls, body);
 	_el.innerHTML = _html;
 	return _el.children[0].children[0];
+	return _el.children[0].children[0].children[0];
 };
 /** comments **/
 var removeInlineForm = function(form) {
 	form.parentNode.removeChild(form);
 };
 var createInlineForm = function(parent_tr, f_path, line) {
 	var tmpl = YUD.get('comment-inline-form-template').innerHTML;
 	tmpl = tmpl.format(f_path, line);
 	var form = tableTr('comment-form-inline',tmpl)
@@ @@ -436,31 +435,29 @@ var injectInlineForm = function(tr){ @@
 	  var parent = tr;
 	  while (1){
 		  var n = parent.nextElementSibling;
 		  // next element are comments !
 		  if(YUD.hasClass(n,'inline-comments')){
 			  parent = n;
+		  }
 		  else{
 			  break;
+		  }
+	  }
 	  YUD.insertAfter(form,parent);
 	  var f = YUD.get(form);
 	  var overlay = YUD.getElementsByClassName('overlay',null,f)[0];
 	  var _form = YUD.getElementsByClassName('inline-form',null,f)[0];
-	  form.on('submit',function(e){
+	  YUE.on(YUD.get(_form), 'submit',function(e){
 		  YUE.preventDefault(e);
 		  //ajax submit
 		  var text = YUD.get('text_'+lineno).value;
 		  var postData = {
 	            'text':text,
 	            'f_path':f_path,
 	            'line':lineno
 		  };
 		  if(lineno === undefined){
 			  alert('missing line !');

0 comments (0 inline, 0 general)