kallithea Changeset - d46d9d93305a

Changeset - d46d9d93305a

Parent rev.

Child rev.

[Not reviewed]

default

0 1 0

Mads Kiilerich - 12 years ago 2013-06-12 01:36:35
madski@unity3d.com

Transplanted from: 5c084ff10ca2

diff: drop "confirm to show potentially huge diff" click-through

It is obvious from the context that the diff was cut off to use resources efficiently.
The user clicked "Show full diff" because he wanted the diff anyway. Asking
twice is just annoying and serves no purpose.

1 file changed with 2 insertions and 2 deletions:

rhodecode/templates/compare/compare_diff.html

0 comments (0 inline, 0 general)

rhodecode/templates/compare/compare_diff.html

➞

Show inline comments

@@ @@ -55,7 +55,7 @@ ${self.context_bar('changelog')} @@
               %endfor
             </div>
             % if c.limited_diff:
-              <h5>${_('Changeset was too big and was cut off...')} <a href="${h.url.current(fulldiff=1, **request.GET.mixed())}" onclick="return confirm('${_("confirm to show potentially huge diff")}')">${_('Show full diff')}</a></h5>
+              <h5>${_('Changeset was too big and was cut off...')} <a href="${h.url.current(fulldiff=1, **request.GET.mixed())}">${_('Show full diff')}</a></h5>
             % endif
         </div>
     </div>
@@ @@ -66,7 +66,7 @@ ${self.context_bar('changelog')} @@
       ${diff_block.diff_block_simple([c.changes[fid]])}
     %endfor
     % if c.limited_diff:
-      <h4>${_('Changeset was too big and was cut off...')} <a href="${h.url.current(fulldiff=1, **request.GET.mixed())}" onclick="return confirm('${_("confirm to show potentially huge diff")}')">${_('Show full diff')}</a></h4>
       <h4>${_('Changeset was too big and was cut off...')} <a href="${h.url.current(fulldiff=1, **request.GET.mixed())}">${_('Show full diff')}</a></h4>
     % endif
      <script type="text/javascript">

0 comments (0 inline, 0 general)