kallithea Changeset - d9fc7312177e

Changeset - d9fc7312177e

Parent rev.

Child rev.

[Not reviewed]

default

0 2 0

Thomas De Schampheleire - 8 years ago 2018-02-03 22:29:41
thomas.de_schampheleire@nokia.com

HTML email templates: don't use link color for PR descriptions

The link color should only be used for actual hyperlinks.
Using it for anything else is very confusing for users.

For pullrequest mails, the usage of the link color for the PR description
may have been done to separate the description more clearly from the title
word 'Description' above it.
Instead, use a table with grey background similar to how comments are
displayed. This meets the objective of not abusing link colors as well as
clearly separating the description from the rest of the mail.

2 files changed with 45 insertions and 3 deletions:

kallithea/templates/email_templates/pull_request.html

kallithea/tests/models/test_dump_html_mails.ref.html

0 comments (0 inline, 0 general)

kallithea/templates/email_templates/pull_request.html

➞

Show inline comments

@@ @@ -40,7 +40,21 @@ @@
     <tr><td height="10px" style="height:10px"></td></tr>
     <tr>
         <td>
             <div style="${comment_style};color:${color_link}">${body}</div>
             <table cellpadding="0" cellspacing="0" width="100%" border="0" bgcolor="${color_background_grey}" style="border:1px solid ${color_border};border-radius:4px">
                 <tr>
                     <td height="10px" style="height:10px" colspan="3"></td>
                 </tr>
                 <tr>
                     <td width="20px" style="width:20px"></td>
                     <td>
                         <div style="${comment_style}">${body}</div>
                     </td>
                     <td width="20px" style="width:20px"></td>
                 </tr>
                 <tr>
                     <td height="10px" style="height:10px" colspan="3"></td>
                 </tr>
             </table>
         </td>
     </tr>
     <tr><td height="15px" style="height:15px"></td></tr>

kallithea/tests/models/test_dump_html_mails.ref.html

➞

Show inline comments

@@ @@ -987,7 +987,21 @@ View Pull Request: http://pr.org/7 @@
     <tr><td height="10px" style="height:10px"></td></tr>
     <tr>
         <td>
             <div style="font-family:Lucida Console,Consolas,Monaco,Inconsolata,Liberation Mono,monospace;white-space:pre-wrap;color:#395fa0"><div class="formatted-fixed">This PR is &#39;awesome&#39; because it does &lt;stuff&gt;<br/> - please approve indented!</div></div>
             <table cellpadding="0" cellspacing="0" width="100%" border="0" bgcolor="#f9f9f9" style="border:1px solid #ddd;border-radius:4px">
                 <tr>
                     <td height="10px" style="height:10px" colspan="3"></td>
                 </tr>
                 <tr>
                     <td width="20px" style="width:20px"></td>
                     <td>
                         <div style="font-family:Lucida Console,Consolas,Monaco,Inconsolata,Liberation Mono,monospace;white-space:pre-wrap"><div class="formatted-fixed">This PR is &#39;awesome&#39; because it does &lt;stuff&gt;<br/> - please approve indented!</div></div>
                     </td>
                     <td width="20px" style="width:20px"></td>
                 </tr>
                 <tr>
                     <td height="10px" style="height:10px" colspan="3"></td>
                 </tr>
             </table>
         </td>
     </tr>
     <tr><td height="15px" style="height:15px"></td></tr>
@@ @@ -1162,7 +1176,21 @@ View Pull Request: http://pr.org/7 @@
     <tr><td height="10px" style="height:10px"></td></tr>
     <tr>
         <td>
             <div style="font-family:Lucida Console,Consolas,Monaco,Inconsolata,Liberation Mono,monospace;white-space:pre-wrap;color:#395fa0"><div class="formatted-fixed">This PR is &#39;awesome&#39; because it does &lt;stuff&gt;<br/> - please approve indented!</div></div>
             <table cellpadding="0" cellspacing="0" width="100%" border="0" bgcolor="#f9f9f9" style="border:1px solid #ddd;border-radius:4px">
                 <tr>
                     <td height="10px" style="height:10px" colspan="3"></td>
                 </tr>
                 <tr>
                     <td width="20px" style="width:20px"></td>
                     <td>
                         <div style="font-family:Lucida Console,Consolas,Monaco,Inconsolata,Liberation Mono,monospace;white-space:pre-wrap"><div class="formatted-fixed">This PR is &#39;awesome&#39; because it does &lt;stuff&gt;<br/> - please approve indented!</div></div>
                     </td>
                     <td width="20px" style="width:20px"></td>
                 </tr>
                 <tr>
                     <td height="10px" style="height:10px" colspan="3"></td>
                 </tr>
             </table>
         </td>
     </tr>
     <tr><td height="15px" style="height:15px"></td></tr>

0 comments (0 inline, 0 general)