kallithea Changeset - e26c11b68850

Changeset - e26c11b68850

Parent rev.

Child rev.

[Not reviewed]

beta

0 2 0

Marcin Kuzminski - 13 years ago 2012-12-14 03:31:44
marcin@python-works.com

remove reviewers button removes them without need of hitting save button.

2 files changed with 11 insertions and 9 deletions:

rhodecode/public/js/rhodecode.js

rhodecode/templates/pullrequests/pullrequest_show.html

0 comments (0 inline, 0 general)

rhodecode/public/js/rhodecode.js

➞

Show inline comments

@@ @@ -712,6 +712,14 @@ var deleteComment = function(comment_id) @@
+}
 var updateReviewers = function(reviewers_ids){
 	if (reviewers_ids === undefined){
   	  var reviewers_ids = [];
 	  var ids = YUQ('#review_members input');
 	  for(var i=0; i<ids.length;i++){
 		  var id = ids[i].value
 		  reviewers_ids.push(id);
+	  }
+	}
 	var url = AJAX_UPDATE_PULLREQUEST;
 	var postData = {'_method':'put',
 			        'reviewers_ids': reviewers_ids};
@@ @@ -852,6 +860,7 @@ var removeReviewer = function(reviewer_i @@
 	if (el.parentNode !== undefined){
 		el.parentNode.removeChild(el);
+	}
 	updateReviewers();
+}
 var fileBrowserListeners = function(current_url, node_list_url, url_base){

rhodecode/templates/pullrequests/pullrequest_show.html

➞

Show inline comments

@@ @@ -198,16 +198,9 @@ @@
           // inject comments into they proper positions
           var file_comments = YUQ('.inline-comment-placeholder');
           renderInlineComments(file_comments);
           YUE.on(YUD.get('update_pull_request'),'click',function(e){
         	  var reviewers_ids = [];
         	  var ids = YUQ('#review_members input');
         	  for(var i=0; i<ids.length;i++){
         		  var id = ids[i].value
         		  reviewers_ids.push(id);
+        	  }
         	  updateReviewers(reviewers_ids);
         	  updateReviewers();
           })
       })
     </script>

0 comments (0 inline, 0 general)