kallithea Changeset - e4721f7ba042

Changeset - e4721f7ba042

Parent rev.

Child rev.

[Not reviewed]

default

0 1 0

Takumi IINO - 11 years ago 2014-11-29 08:31:09
trot.thunder@gmail.com

javascripts: plain javascript version q_filter without YAHOO.namespace

1 file changed with 38 insertions and 29 deletions:

kallithea/public/js/base.js

0 comments (0 inline, 0 general)

kallithea/public/js/base.js

➞

Show inline comments

@@ @@ -538,85 +538,94 @@ var _show_tooltip = function(e, tipText) @@
 var _move_tooltip = function(e){
     e.stopImmediatePropagation();
     var $tipBox = $('#tip-box');
     $tipBox.css('top', (e.pageY + 15) + 'px');
     $tipBox.css('left', (e.pageX + 15) + 'px');
 };
 var _close_tooltip = function(e){
     e.stopImmediatePropagation();
     var $tipBox = $('#tip-box');
     $tipBox.hide();
     var el = e.currentTarget;
     $(el).attr('title', $(el).attr('tt_title'));
 };
 /**
  * Quick filter widget
+ *
  * @param target: filter input target
  * @param nodes: list of nodes in html we want to filter.
  * @param display_element function that takes current node from nodes and
  *    does hide or show based on the node
  */
 var q_filter = function(target, $nodes, display_element) {
     var $nodes = $nodes;
     var $q_filter_field = $('#' + target);
     var F = YAHOO.namespace(target);
 var q_filter = (function() {
     var _namespace = {};
     var namespace = function (target) {
         if (!(target in _namespace)) {
             _namespace[target] = {};
+        }
         return _namespace[target];
     };
     return function (target, $nodes, display_element) {
         var $nodes = $nodes;
         var $q_filter_field = $('#' + target);
         var F = namespace(target);
     $q_filter_field.keyup(function (e) {
         clearTimeout(F.filterTimeout);
         F.filterTimeout = setTimeout(F.updateFilter, 600);
     });
         $q_filter_field.keyup(function (e) {
             clearTimeout(F.filterTimeout);
             F.filterTimeout = setTimeout(F.updateFilter, 600);
         });
     F.filterTimeout = null;
     F.updateFilter = function () {
         // Reset timeout
         F.filterTimeout = null;
         var obsolete = [];
         F.updateFilter = function () {
             // Reset timeout
             F.filterTimeout = null;
         var req = $q_filter_field.val().toLowerCase();
             var obsolete = [];
             var req = $q_filter_field.val().toLowerCase();
         var showing = 0;
         $nodes.each(function () {
             var n = this;
             var target_element = display_element(n);
             if (req && n.innerHTML.toLowerCase().indexOf(req) == -1) {
                 $(target_element).hide();
+            }
             else{
                 $(target_element).show();
                 showing += 1;
+            }
         });
             var showing = 0;
             $nodes.each(function () {
                 var n = this;
                 var target_element = display_element(n);
                 if (req && n.innerHTML.toLowerCase().indexOf(req) == -1) {
                     $(target_element).hide();
+                }
                 else {
                     $(target_element).show();
                     showing += 1;
+                }
             });
         $('#repo_count').html(showing);
         /* FIXME: don't hardcode */
             $('#repo_count').html(showing);
             /* FIXME: don't hardcode */
+        }
+    }
 };
+})();
 /* return jQuery expression with a tr with body in 3rd column and class cls and id named after the body */
 var _table_tr = function(cls, body){
     // like: <div class="comment" id="comment-8" line="o92"><div class="comment-wrapp">...
     // except new inlines which are different ...
     var comment_id = ($(body).attr('id') || 'comment-new').split('comment-')[1];
     var tr_id = 'comment-tr-{0}'.format(comment_id);
     return $(('<tr id="{0}" class="{1}">'+
                   '<td class="lineno-inline new-inline"></td>'+
                   '<td class="lineno-inline old-inline"></td>'+
                   '<td>{2}</td>'+
                  '</tr>').format(tr_id, cls, body));
 };
 /** return jQuery expression with new inline form based on template **/
 var _createInlineForm = function(parent_tr, f_path, line) {
     var $tmpl = $('#comment-inline-form-template').html().format(f_path, line);
     var $form = _table_tr('comment-form-inline', $tmpl)
     // create event for hide button
     $form.find('.hide-inline-form').click(function(e) {
         var newtr = e.currentTarget.parentNode.parentNode.parentNode.parentNode.parentNode;
         if($(newtr).next().hasClass('inline-comments-button')){
             $(newtr).next().show();

0 comments (0 inline, 0 general)