kallithea Changeset - e4f743999d5c

Changeset - e4f743999d5c

Parent rev.

Child rev.

[Not reviewed]

default

0 2 0

Mads Kiilerich - 6 years ago 2020-01-02 22:18:59
mads@kiilerich.com

Grafted from: afb356c8040f

lib: de-obfuscate nested functions in pygmentize_annotation and how they always pass an annotate_from_changeset_func to AnnotateHtmlFormatter

These functions contain the only call to annotate_highlight, which contains
the only call to AnnotateHtmlFormatter.

annotate_highlight is thus clearly always passed an
annotate_from_changeset_func.

2 files changed with 25 insertions and 37 deletions:

kallithea/lib/annotate.py

kallithea/lib/helpers.py

0 comments (0 inline, 0 general)

kallithea/lib/annotate.py

➞

Show inline comments

@@ @@ -33,7 +33,7 @@ from kallithea.lib.vcs.nodes import File @@
 from kallithea.lib.vcs.utils import safe_unicode
-def annotate_highlight(filenode, annotate_from_changeset_func=None,
 def annotate_highlight(filenode, annotate_from_changeset_func,
         order=None, headers=None, **options):
     """
     Returns html portion containing annotated table with 3 columns: line
@@ @@ -50,9 +50,9 @@ def annotate_highlight(filenode, annotat @@
     """
     from kallithea.lib.pygmentsutils import get_custom_lexer
     options['linenos'] = True
     formatter = AnnotateHtmlFormatter(filenode=filenode, order=order,
         headers=headers,
         annotate_from_changeset_func=annotate_from_changeset_func, **options)
     formatter = AnnotateHtmlFormatter(filenode=filenode,
         annotate_from_changeset_func=annotate_from_changeset_func, order=order,
         headers=headers, **options)
     lexer = get_custom_lexer(filenode.extension) or filenode.lexer
     highlighted = highlight(safe_unicode(filenode.content), lexer, formatter)
     return highlighted
@@ @@ -60,10 +60,10 @@ def annotate_highlight(filenode, annotat @@
 class AnnotateHtmlFormatter(HtmlFormatter):
-    def __init__(self, filenode, annotate_from_changeset_func=None,
     def __init__(self, filenode, annotate_from_changeset_func,
             order=None, **options):
         """
-        If ``annotate_from_changeset_func`` is passed it should be a function
+        ``annotate_from_changeset_func`` must be a function
         which returns string from the given changeset. For example, we may pass
         following function as ``annotate_from_changeset_func``::
@@ @@ -100,15 +100,6 @@ class AnnotateHtmlFormatter(HtmlFormatte @@
             raise VCSError("This formatter expect FileNode parameter, not %r"
                 % type(filenode))
     def annotate_from_changeset(self, changeset):
         """
         Returns full html line for single changeset per annotated line.
         """
         if self.annotate_from_changeset_func:
             return self.annotate_from_changeset_func(changeset)
         else:
             return ''.join((changeset.id, '\n'))
     def _wrap_tablelinenos(self, inner):
         inner_lines = []
         lncount = 0
@@ @@ -165,7 +156,7 @@ class AnnotateHtmlFormatter(HtmlFormatte @@
 #        ln_ = len(ls.splitlines())
 #        if  ln_cs > ln_:
 #            annotate_changesets = annotate_changesets[:ln_ - ln_cs]
-        annotate = ''.join((self.annotate_from_changeset(el[2]())
+        annotate = ''.join((self.annotate_from_changeset_func(el[2]())
                             for el in self.filenode.annotate))
         # in case you wonder about the seemingly redundant <div> here:
         # since the content in the other cell also is wrapped in a div,

kallithea/lib/helpers.py

➞

Show inline comments

@@ @@ -333,22 +333,6 @@ def pygmentize(filenode, **kwargs): @@
         code_highlight(safe_unicode(filenode.content), lexer, CodeHtmlFormatter(**kwargs))))
 def pygmentize_annotation(repo_name, filenode, **kwargs):
     """
     pygmentize function for annotation
     :param filenode:
     """
     color_dict = {}
     def gen_color(n=10000):
         """generator for getting n of evenly distributed colors using
         hsv color and golden ratio. It always return same order of colors
         :returns: RGB tuple
         """
         def hsv_to_rgb(h, s, v):
             if s == 0.0:
                 return v, v, v
@@ @@ -371,6 +355,14 @@ def pygmentize_annotation(repo_name, fil @@
             if i == 5:
                 return v, p, q
 def gen_color(n=10000):
     """generator for getting n of evenly distributed colors using
     hsv color and golden ratio. It always return same order of colors
     :returns: RGB tuple
     """
         golden_ratio = 0.618033988749895
         h = 0.22717784590367374
@@ @@ -381,7 +373,15 @@ def pygmentize_annotation(repo_name, fil @@
             RGB_tuple = hsv_to_rgb(*HSV_tuple)
             yield [str(int(x * 256)) for x in RGB_tuple]
 def pygmentize_annotation(repo_name, filenode, **kwargs):
     """
     pygmentize function for annotation
     :param filenode:
     """
     cgenerator = gen_color()
     color_dict = {}
     def get_color_string(cs):
         if cs in color_dict:
@@ @@ -390,9 +390,7 @@ def pygmentize_annotation(repo_name, fil @@
             col = color_dict[cs] = cgenerator.next()
         return "color: rgb(%s)! important;" % (', '.join(col))
     def url_func(repo_name):
         def _url_func(changeset):
     def url_func(changeset):
             author = escape(changeset.author)
             date = changeset.date
             message = escape(changeset.message)
@@ @@ -412,9 +410,8 @@ def pygmentize_annotation(repo_name, fil @@
             uri += '\n'
             return uri
         return _url_func
-    return literal(markup_whitespace(annotate_highlight(filenode, url_func(repo_name), **kwargs)))
     return literal(markup_whitespace(annotate_highlight(filenode, url_func, **kwargs)))
 class _Message(object):

0 comments (0 inline, 0 general)