Changeset - e6b9194ab3f8
[Not reviewed]
default
0 1 0
Mads Kiilerich - 6 years ago 2019-08-18 19:50:49
mads@kiilerich.com
Grafted from: 0f89c35eafde
scm: select options should be tuples - not lists with 2 elements

We use tuples in all(?) other places, so we should do the same here.

Since lists can be unpacked as tuples, it currently works to use 2-lists. But
in a following change for "correct" handling of webhelpers.select when using
webhelpers2.select, we want to give special handling to tuples vs strings vs
Options. We don't want to add list to that list.
1 file changed with 1 insertions and 1 deletions:
0 comments (0 inline, 0 general)
kallithea/model/scm.py
Show inline comments
 
@@ -662,13 +662,13 @@ class ScmModel(object):
 
        :param repo:
 
        """
 

	
 
        hist_l = []
 
        choices = []
 
        repo = self.__get_repo(repo)
 
        hist_l.append(['rev:tip', _('latest tip')])
 
        hist_l.append(('rev:tip', _('latest tip')))
 
        choices.append('rev:tip')
 
        if repo is None:
 
            return choices, hist_l
 

	
 
        repo = repo.scm_instance
 

	
0 comments (0 inline, 0 general)