kallithea Changeset - e7daa6a752ce

Changeset - e7daa6a752ce

Parent rev.

Child rev.

[Not reviewed]

beta

0 1 0

Mads Kiilerich - 13 years ago 2013-01-29 03:19:28
madski@unity3d.com

pull requeset: use #pr and title in comment notifications

1 file changed with 5 insertions and 3 deletions:

rhodecode/model/comment.py

0 comments (0 inline, 0 general)

rhodecode/model/comment.py

➞

Show inline comments

@@ @@ -83,25 +83,24 @@ class ChangesetCommentsModel(BaseModel): @@
         comment.author = user
         comment.text = text
         comment.f_path = f_path
         comment.line_no = line_no
         if revision:
             cs = repo.scm_instance.get_changeset(revision)
             desc = "%s - %s" % (cs.short_id, h.shorter(cs.message, 256))
             comment.revision = revision
         elif pull_request:
             pull_request = self.__get_pull_request(pull_request)
             comment.pull_request = pull_request
             desc = pull_request.pull_request_id
         else:
             raise Exception('Please specify revision or pull_request_id')
         self.sa.add(comment)
         self.sa.flush()
         # make notification
         line = ''
         body = text
         #changeset
         if revision:
@@ @@ -129,26 +128,29 @@ class ChangesetCommentsModel(BaseModel): @@
             email_kwargs = {
                 'status_change': status_change,
+            }
         #pull request
         elif pull_request:
             _url = h.url('pullrequest_show',
                 repo_name=pull_request.other_repo.repo_name,
                 pull_request_id=pull_request.pull_request_id,
                 anchor='comment-%s' % comment.comment_id,
                 qualified=True,
+            )
             subj = safe_unicode(
                 h.link_to('Re pull request: %(desc)s %(line)s' % \
                           {'desc': desc, 'line': line}, _url)
                 h.link_to('Re pull request #%(pr_id)s: %(desc)s %(line)s' % \
                           {'desc': comment.pull_request.title,
                            'pr_id': comment.pull_request.pull_request_id,
                            'line': line},
                           _url)
+            )
             notification_type = Notification.TYPE_PULL_REQUEST_COMMENT
             # get the current participants of this pull request
             recipients = ChangesetComment.get_users(pull_request_id=
                                                 pull_request.pull_request_id)
             # add pull request author
             recipients += [pull_request.author]
             # add the reviewers to notification
             recipients += [x.user for x in pull_request.reviewers]

0 comments (0 inline, 0 general)