kallithea Changeset - e85f5bf7ad74

Changeset - e85f5bf7ad74

Parent rev.

Child rev.

[Not reviewed]

default

1 2 0

Mads Kiilerich - 5 years ago 2020-08-23 23:14:21
mads@kiilerich.com

Grafted from: f053b0225711

middleware: drop sentry support

Our sentry support didn't seem to work with py3. It doesn't seem to ever have
been tested on py3 - it failed already when installing.

It seems like we used the 'legacy client':
https://docs.sentry.io/clients/python/
and nowadays one is expected to use:
https://docs.sentry.io/platforms/python/
which has integrations for Pyramid and other frameworks (but not TG2). There
are Celery and SQLAlchemy integrations too. See also the migration guide:
https://docs.sentry.io/platforms/python/migration/ .

Also, there is not much essential code in the old sentry support, and it seems
like it would be easier to reimplement from scratch. There is thus not much
lost by dropping it.

3 files changed with 0 insertions and 72 deletions:

development.ini

kallithea/lib/middleware/sentry.py

kallithea/lib/paster_commands/template.ini.mako

0 comments (0 inline, 0 general)

development.ini

➞

Show inline comments

@@ @@ -325,49 +325,48 @@ session.secret = development-not-secret @@
 ## Show a nice error page for application HTTP errors and exceptions (default true)
 #errorpage.enabled = true
 ## Enable Backlash client-side interactive debugger (default false)
 ## WARNING: *THIS MUST BE false IN PRODUCTION ENVIRONMENTS!!!*
 ## This debug mode will allow all visitors to execute malicious code.
 #debug = false
 debug = true
 ## Enable Backlash server-side error reporting (unless debug mode handles it client-side) (default true)
 #trace_errors.enable = true
 ## Errors will be reported by mail if trace_errors.error_email is set.
 ## Propagate email settings to ErrorReporter of TurboGears2
 ## You do not normally need to change these lines
 get trace_errors.smtp_server = smtp_server
 get trace_errors.smtp_port = smtp_port
 get trace_errors.from_address = error_email_from
 get trace_errors.error_email = email_to
 get trace_errors.smtp_username = smtp_username
 get trace_errors.smtp_password = smtp_password
 get trace_errors.smtp_use_tls = smtp_use_tls
 ##################################
 ##        LOGVIEW CONFIG        ##
 ##################################
 logview.sqlalchemy = #faa
 logview.pylons.templating = #bfb
 logview.pylons.util = #eee
 #########################
 ##      DB CONFIG      ##
 #########################
 sqlalchemy.url = sqlite:///%(here)s/kallithea.db?timeout=60
 #sqlalchemy.url = postgresql://kallithea:password@localhost/kallithea
 #sqlalchemy.url = mysql://kallithea:password@localhost/kallithea?charset=utf8mb4
 ## Note: the mysql:// prefix should also be used for MariaDB
 sqlalchemy.pool_recycle = 3600
 ################################
 ##   ALEMBIC CONFIGURATION    ##
 ################################
 [alembic]

kallithea/lib/middleware/sentry.py

➞

Show inline comments

deleted file

kallithea/lib/paster_commands/template.ini.mako

➞

Show inline comments

@@ @@ -398,69 +398,48 @@ session.secret = ${uuid()} @@
 <%text>##</%text>##################################
 <%text>##</%text> Show a nice error page for application HTTP errors and exceptions (default true)
 #errorpage.enabled = true
 <%text>##</%text> Enable Backlash client-side interactive debugger (default false)
 <%text>##</%text> WARNING: *THIS MUST BE false IN PRODUCTION ENVIRONMENTS!!!*
 <%text>##</%text> This debug mode will allow all visitors to execute malicious code.
 #debug = false
 <%text>##</%text> Enable Backlash server-side error reporting (unless debug mode handles it client-side) (default true)
 #trace_errors.enable = true
 <%text>##</%text> Errors will be reported by mail if trace_errors.error_email is set.
 <%text>##</%text> Propagate email settings to ErrorReporter of TurboGears2
 <%text>##</%text> You do not normally need to change these lines
 get trace_errors.smtp_server = smtp_server
 get trace_errors.smtp_port = smtp_port
 get trace_errors.from_address = error_email_from
 get trace_errors.error_email = email_to
 get trace_errors.smtp_username = smtp_username
 get trace_errors.smtp_password = smtp_password
 get trace_errors.smtp_use_tls = smtp_use_tls
 %if error_aggregation_service == 'sentry':
 <%text>##</%text>##############
 <%text>##</%text>  [sentry]  ##
 <%text>##</%text>##############
 <%text>##</%text> sentry is a alternative open source error aggregator
 <%text>##</%text> you must install python packages `sentry` and `raven` to enable
 sentry.dsn = YOUR_DNS
 sentry.servers =
 sentry.name =
 sentry.key =
 sentry.public_key =
 sentry.secret_key =
 sentry.project =
 sentry.site =
 sentry.include_paths =
 sentry.exclude_paths =
 %endif
 <%text>##</%text>################################
 <%text>##</%text>        LOGVIEW CONFIG        ##
 <%text>##</%text>################################
 logview.sqlalchemy = #faa
 logview.pylons.templating = #bfb
 logview.pylons.util = #eee
 <%text>##</%text>#######################
 <%text>##</%text>      DB CONFIG      ##
 <%text>##</%text>#######################
 %if database_engine == 'sqlite':
 sqlalchemy.url = sqlite:///%(here)s/kallithea.db?timeout=60
 %else:
 #sqlalchemy.url = sqlite:///%(here)s/kallithea.db?timeout=60
 %endif
 %if database_engine == 'postgres':
 sqlalchemy.url = postgresql://kallithea:password@localhost/kallithea
 %else:
 #sqlalchemy.url = postgresql://kallithea:password@localhost/kallithea
 %endif
 %if database_engine == 'mysql':
 sqlalchemy.url = mysql://kallithea:password@localhost/kallithea?charset=utf8mb4

0 comments (0 inline, 0 general)