kallithea Changeset - ecc2a13a308d

Changeset - ecc2a13a308d

Parent rev.

Child rev.

[Not reviewed]

default

0 2 0

Mads Kiilerich - 9 years ago 2016-05-23 18:02:33
madski@unity3d.com

pullrequests: use css for description instead of <code> and explicit styling

b60e58094fb7 introduced use of <code>, but that is semantically incorrect.

2 files changed with 7 insertions and 1 deletions:

kallithea/public/css/style.css

kallithea/templates/pullrequests/pullrequest_show.html

0 comments (0 inline, 0 general)

kallithea/public/css/style.css

➞

Show inline comments

@@ @@ -157,17 +157,23 @@ div.options a { @@
+}
 code,
 .code pre,
 div.readme .readme_box pre,
 div.rst-block pre,
 div.formatted-fixed,
 .CodeMirror .CodeMirror-code pre {
     font-size: 12px;
     font-family: Lucida Console, Consolas, Monaco, Inconsolata, Liberation Mono, monospace;
+}
 div.formatted-fixed {
     white-space: pre-wrap;
     line-height: 14px;
+}
 .top-left-rounded-corner {
     border-top-left-radius: 8px;
+}
 .top-right-rounded-corner {
     border-top-right-radius: 8px;

kallithea/templates/pullrequests/pullrequest_show.html

➞

Show inline comments

@@ @@ -40,13 +40,13 @@ ${self.repo_context_bar('showpullrequest @@
             <div style="margin: 5px">
               <a class="btn btn-small" onclick="$('.pr-do-edit').show();$('.pr-not-edit').hide()">${_("Edit")}</a>
             </div>
             %endif
           </div>
           <div class="input">
-            <code style="white-space:pre-wrap; line-height: 14px">${h.urlify_commit(c.pull_request.description, c.pull_request.org_repo.repo_name)}</code>
+            <div class="formatted-fixed">${h.urlify_commit(c.pull_request.description, c.pull_request.org_repo.repo_name)}</div>
           </div>
         </div>
         %if editable:
         <div class="pr-do-edit" style="display:none">
           <div class="field">

0 comments (0 inline, 0 general)