kallithea Changeset - f028c24a714d

Changeset - f028c24a714d

Parent rev.

Child rev.

[Not reviewed]

default

0 2 0

Thomas De Schampheleire - 8 years ago 2018-02-03 22:01:46
thomas.de_schampheleire@nokia.com

HTML email templates: Outlook: fix list bullets

The rendering of HTML emails in Outlook is very restricted and based on old
Internet Explorer versions (more or less the same rendering as in Microsoft
Word). To make the Kallithea emails look the same as in the browser, some
adaptations are needed.

List bullets (to identify different changesets in pullrequests) are not
shown in Outlook. In order to fix that, a proprietary CSS property is
required.
Fix found via:
https://litmus.com/community/discussions/752-can-we-use-ul-and-li-in-email

2 files changed with 5 insertions and 5 deletions:

kallithea/templates/email_templates/pull_request.html

kallithea/tests/models/test_dump_html_mails.ref.html

0 comments (0 inline, 0 general)

kallithea/templates/email_templates/pull_request.html

➞

Show inline comments

@@ @@ -55,7 +55,7 @@ @@
         <td style="${sans_style}">
             <ul style="color:${color_link};padding-left:15px;margin:0">
                 %for revision, desc in pr_revisions:
                     <li>
+                    <li style="mso-special-format:bullet">
                         <a style="color:${color_link};text-decoration:none"
                            href="${h.canonical_url('changeset_home', repo_name=org_repo_name, revision=revision)}">
                             ${h.shorter(desc, 80, firstline=True)}

kallithea/tests/models/test_dump_html_mails.ref.html

➞

Show inline comments

@@ @@ -1001,13 +1001,13 @@ View Pull Request: http://pr.org/7 @@
     <tr>
         <td style="font-family:Helvetica,Arial,sans-serif">
             <ul style="color:#395fa0;padding-left:15px;margin:0">
                     <li>
+                    <li style="mso-special-format:bullet">
                         <a style="color:#395fa0;text-decoration:none"
                            href="http://changeset_home/?repo_name=repo_org&amp;revision=123abc123abc123abc123abc123abc123abc123abc">
                             Introduce one and two
                         </a>
                     </li>
                     <li>
+                    <li style="mso-special-format:bullet">
                         <a style="color:#395fa0;text-decoration:none"
                            href="http://changeset_home/?repo_name=repo_org&amp;revision=567fed567fed567fed567fed567fed567fed567fed">
                             Make one plus two equal tree
@@ @@ -1176,13 +1176,13 @@ View Pull Request: http://pr.org/7 @@
     <tr>
         <td style="font-family:Helvetica,Arial,sans-serif">
             <ul style="color:#395fa0;padding-left:15px;margin:0">
                     <li>
+                    <li style="mso-special-format:bullet">
                         <a style="color:#395fa0;text-decoration:none"
                            href="http://changeset_home/?repo_name=repo_org&amp;revision=123abc123abc123abc123abc123abc123abc123abc">
                             Introduce one and two
                         </a>
                     </li>
                     <li>
+                    <li style="mso-special-format:bullet">
                         <a style="color:#395fa0;text-decoration:none"
                            href="http://changeset_home/?repo_name=repo_org&amp;revision=567fed567fed567fed567fed567fed567fed567fed">
                             Make one plus two equal tree

0 comments (0 inline, 0 general)