Changeset - f028c24a714d
Parent rev.
Child rev.
[Not reviewed]
default
0 2 0
Thomas De Schampheleire - 8 years ago 2018-02-03 22:01:46
thomas.de_schampheleire@nokia.com
HTML email templates: Outlook: fix list bullets

The rendering of HTML emails in Outlook is very restricted and based on old
Internet Explorer versions (more or less the same rendering as in Microsoft
Word). To make the Kallithea emails look the same as in the browser, some
adaptations are needed.

List bullets (to identify different changesets in pullrequests) are not
shown in Outlook. In order to fix that, a proprietary CSS property is
required.
Fix found via:
https://litmus.com/community/discussions/752-can-we-use-ul-and-li-in-email
2 files changed with 5 insertions and 5 deletions:
kallithea/templates/email_templates/pull_request.html
1
1
kallithea/tests/models/test_dump_html_mails.ref.html
4
4
0 comments (0 inline, 0 general)
kallithea/templates/email_templates/pull_request.html
➞
Show inline comments
 
@@ -34,40 +34,40 @@
 
        <td>
 
            <div>
 
                ${_('Description')}:
 
            </div>
 
        </td>
 
    </tr>
 
    <tr><td height="10px" style="height:10px"></td></tr>
 
    <tr>
 
        <td>
 
            <div style="${comment_style};color:${color_link}">${body}</div>
 
        </td>
 
    </tr>
 
    <tr><td height="15px" style="height:15px"></td></tr>
 
    <tr>
 
        <td>
 
            <div>${_('Changesets')}:</div>
 
        </td>
 
    </tr>
 
    <tr><td height="10px" style="height:10px"></td></tr>
 

			




	
	
	
		
 
    <tr>

			




	
	
	
		
 
        <td style="${sans_style}">

			




	
	
	
		
 
            <ul style="color:${color_link};padding-left:15px;margin:0">

			




	
	
	
		
 
                %for revision, desc in pr_revisions:

			




	
	
	
		
 
                    <li>

			




	
	
	
		
 
                    <li style="mso-special-format:bullet">

			




	
	
	
		
 
                        <a style="color:${color_link};text-decoration:none"

			




	
	
	
		
 
                           href="${h.canonical_url('changeset_home', repo_name=org_repo_name, revision=revision)}">

			




	
	
	
		
 
                            ${h.shorter(desc, 80, firstline=True)}

			




	
	
	
		
 
                        </a>

			




	
	
	
		
 
                    </li>

			




	
	
	
		
 
                %endfor

			




	
	
	
		
 
            </ul>

			




	
	
	
		
 
        </td>

			




	
	
	
		
 
    </tr>

			




	
	
	
		
 
    <tr>

			




	
	
	
		
 
        <td>

			




	
	
	
		
 
<%include file="button.html" args="url=pr_url,title=_('View Pull Request'),padding_bottom=False"/>\

			




	
	
	
		
 
        </td>

			




	
	
	
		
 
    </tr>

			




	
	
	
		
 
</table>

			




        

    


    
    

    

        

                

                    kallithea/tests/models/test_dump_html_mails.ref.html
                

                

                  
                      
                        

                      ➞

                      
                        
                  

                  
                      
                  
                      
                  
                      
                  
                      
                  
                  
                

                

                    Show inline comments
                    
                

        

        

            



	
	
		
 
@@ -980,55 +980,55 @@ View Pull Request: http://pr.org/7

			




	
	
	
		
 
    <tr>

			




	
	
	
		
 
        <td>

			




	
	
	
		
 
            <div>

			




	
	
	
		
 
                Description:

			




	
	
	
		
 
            </div>

			




	
	
	
		
 
        </td>

			




	
	
	
		
 
    </tr>

			




	
	
	
		
 
    <tr><td height="10px" style="height:10px"></td></tr>

			




	
	
	
		
 
    <tr>

			




	
	
	
		
 
        <td>

			




	
	
	
		
 
            <div style="font-family:Lucida Console,Consolas,Monaco,Inconsolata,Liberation Mono,monospace;white-space:pre-wrap;color:#395fa0"><div class="formatted-fixed">This PR is awesome because it does stuff<br/> - please approve indented!</div></div>

			




	
	
	
		
 
        </td>

			




	
	
	
		
 
    </tr>

			




	
	
	
		
 
    <tr><td height="15px" style="height:15px"></td></tr>

			




	
	
	
		
 
    <tr>

			




	
	
	
		
 
        <td>

			




	
	
	
		
 
            <div>Changesets:</div>

			




	
	
	
		
 
        </td>

			




	
	
	
		
 
    </tr>

			




	
	
	
		
 
    <tr><td height="10px" style="height:10px"></td></tr>

			




	
	
	
		
 

			




	
	
	
		
 
    <tr>

			




	
	
	
		
 
        <td style="font-family:Helvetica,Arial,sans-serif">

			




	
	
	
		
 
            <ul style="color:#395fa0;padding-left:15px;margin:0">

			




	
	
	
		
 
                    <li>

			




	
	
	
		
 
                    <li style="mso-special-format:bullet">

			




	
	
	
		
 
                        <a style="color:#395fa0;text-decoration:none"

			




	
	
	
		
 
                           href="http://changeset_home/?repo_name=repo_org&amp;revision=123abc123abc123abc123abc123abc123abc123abc">

			




	
	
	
		
 
                            Introduce one and two

			




	
	
	
		
 
                        </a>

			




	
	
	
		
 
                    </li>

			




	
	
	
		
 
                    <li>

			




	
	
	
		
 
                    <li style="mso-special-format:bullet">

			




	
	
	
		
 
                        <a style="color:#395fa0;text-decoration:none"

			




	
	
	
		
 
                           href="http://changeset_home/?repo_name=repo_org&amp;revision=567fed567fed567fed567fed567fed567fed567fed">

			




	
	
	
		
 
                            Make one plus two equal tree

			




	
	
	
		
 
                        </a>

			




	
	
	
		
 
                    </li>

			




	
	
	
		
 
            </ul>

			




	
	
	
		
 
        </td>

			




	
	
	
		
 
    </tr>

			




	
	
	
		
 
    <tr>

			




	
	
	
		
 
        <td>

			




	
	
	
		
 
<center>

			




	
	
	
		
 
    <table cellspacing="0" cellpadding="0" style="margin-left:auto;margin-right:auto">

			




	
	
	
		
 
        <tr>

			




	
	
	
		
 
            <td height="25px" style="height:25px"></td>

			




	
	
	
		
 
        </tr>

			




	
	
	
		
 
        <tr>

			




	
	
	
		
 
            <td style="border-collapse:collapse;border-radius:2px;text-align:center;display:block;border:solid 1px #395fa0;padding:11px 20px 11px 20px">

			




	
	
	
		
 
                <a href="http://pr.org/7" style="text-decoration:none;display:block" target="_blank">

			




	
	
	
		
 
                    <center>

			




	
	
	
		
 
                        <font size="3">

			




	
	
	
		
 
                            <span style="font-family:Helvetica,Arial,sans-serif;font-weight:700;font-size:15px;line-height:14px;color:#395fa0;white-space:nowrap;vertical-align:middle">View Pull Request</span>

			




	
	
	
		
 
                        </font>

			




	
	
	
		
 
                    </center>

			




	
	
	
		
 
                </a>

			




	
	
		
 
@@ -1155,55 +1155,55 @@ View Pull Request: http://pr.org/7

			




	
	
	
		
 
    <tr>

			




	
	
	
		
 
        <td>

			




	
	
	
		
 
            <div>

			




	
	
	
		
 
                Description:

			




	
	
	
		
 
            </div>

			




	
	
	
		
 
        </td>

			




	
	
	
		
 
    </tr>

			




	
	
	
		
 
    <tr><td height="10px" style="height:10px"></td></tr>

			




	
	
	
		
 
    <tr>

			




	
	
	
		
 
        <td>

			




	
	
	
		
 
            <div style="font-family:Lucida Console,Consolas,Monaco,Inconsolata,Liberation Mono,monospace;white-space:pre-wrap;color:#395fa0"><div class="formatted-fixed">This PR is awesome because it does stuff<br/> - please approve indented!</div></div>

			




	
	
	
		
 
        </td>

			




	
	
	
		
 
    </tr>

			




	
	
	
		
 
    <tr><td height="15px" style="height:15px"></td></tr>

			




	
	
	
		
 
    <tr>

			




	
	
	
		
 
        <td>

			




	
	
	
		
 
            <div>Changesets:</div>

			




	
	
	
		
 
        </td>

			




	
	
	
		
 
    </tr>

			




	
	
	
		
 
    <tr><td height="10px" style="height:10px"></td></tr>

			




	
	
	
		
 

			




	
	
	
		
 
    <tr>

			




	
	
	
		
 
        <td style="font-family:Helvetica,Arial,sans-serif">

			




	
	
	
		
 
            <ul style="color:#395fa0;padding-left:15px;margin:0">

			




	
	
	
		
 
                    <li>

			




	
	
	
		
 
                    <li style="mso-special-format:bullet">

			




	
	
	
		
 
                        <a style="color:#395fa0;text-decoration:none"

			




	
	
	
		
 
                           href="http://changeset_home/?repo_name=repo_org&amp;revision=123abc123abc123abc123abc123abc123abc123abc">

			




	
	
	
		
 
                            Introduce one and two

			




	
	
	
		
 
                        </a>

			




	
	
	
		
 
                    </li>

			




	
	
	
		
 
                    <li>

			




	
	
	
		
 
                    <li style="mso-special-format:bullet">

			




	
	
	
		
 
                        <a style="color:#395fa0;text-decoration:none"

			




	
	
	
		
 
                           href="http://changeset_home/?repo_name=repo_org&amp;revision=567fed567fed567fed567fed567fed567fed567fed">

			




	
	
	
		
 
                            Make one plus two equal tree

			




	
	
	
		
 
                        </a>

			




	
	
	
		
 
                    </li>

			




	
	
	
		
 
            </ul>

			




	
	
	
		
 
        </td>

			




	
	
	
		
 
    </tr>

			




	
	
	
		
 
    <tr>

			




	
	
	
		
 
        <td>

			




	
	
	
		
 
<center>

			




	
	
	
		
 
    <table cellspacing="0" cellpadding="0" style="margin-left:auto;margin-right:auto">

			




	
	
	
		
 
        <tr>

			




	
	
	
		
 
            <td height="25px" style="height:25px"></td>

			




	
	
	
		
 
        </tr>

			




	
	
	
		
 
        <tr>

			




	
	
	
		
 
            <td style="border-collapse:collapse;border-radius:2px;text-align:center;display:block;border:solid 1px #395fa0;padding:11px 20px 11px 20px">

			




	
	
	
		
 
                <a href="http://pr.org/7" style="text-decoration:none;display:block" target="_blank">

			




	
	
	
		
 
                    <center>

			




	
	
	
		
 
                        <font size="3">

			




	
	
	
		
 
                            <span style="font-family:Helvetica,Arial,sans-serif;font-weight:700;font-size:15px;line-height:14px;color:#395fa0;white-space:nowrap;vertical-align:middle">View Pull Request</span>

			




	
	
	
		
 
                        </font>

			




	
	
	
		
 
                    </center>

			




	
	
	
		
 
                </a>

			




        

    



    


    



    



      

      





    
    0 comments (0 inline, 0 general)
    





    


  

  







  


    




    








    
        
    
    
        This site is powered by
            Kallithea 0.7.0,
        which is
        © 2010–2025 by various authors & licensed under GPLv3.