kallithea Changeset - fb3b45acd172

Changeset - fb3b45acd172

Parent rev.

Child rev.

[Not reviewed]

default

0 2 0

Mads Kiilerich - 11 years ago 2014-07-18 18:44:54
madski@unity3d.com

repository: don't update changeset cache so much - not in BaseRepoController and only when tip raw_id changed

2 files changed with 3 insertions and 6 deletions:

kallithea/lib/base.py

kallithea/model/db.py

0 comments (0 inline, 0 general)

kallithea/lib/base.py

➞

Show inline comments

@@ @@ -408,15 +408,12 @@ class BaseRepoController(BaseController) @@
             if c.db_repo_scm_instance is None:
                 log.error('%s this repository is present in database but it '
                           'cannot be created as an scm instance', c.repo_name)
                 redirect(url('home'))
             # update last change according to VCS data
             dbr.update_changeset_cache(dbr.get_changeset())
             # some globals counter for menu
             c.repository_followers = self.scm_model.get_followers(dbr)
             c.repository_forks = self.scm_model.get_forks(dbr)
             c.repository_pull_requests = self.scm_model.get_pull_requests(dbr)
             c.repository_following = self.scm_model.is_following_repo(
                                     c.repo_name, self.authuser.user_id)

kallithea/model/db.py

➞

Show inline comments

@@ @@ -1318,24 +1318,24 @@ class Repository(Base, BaseModel): @@
             if scm_repo:
                 cs_cache = scm_repo.get_changeset()
         if isinstance(cs_cache, BaseChangeset):
             cs_cache = cs_cache.__json__()
-        if (cs_cache != self.changeset_cache or not self.changeset_cache):
+        if (not self.changeset_cache or cs_cache['raw_id'] != self.changeset_cache['raw_id']):
             _default = datetime.datetime.fromtimestamp(0)
             last_change = cs_cache.get('date') or _default
             log.debug('updated repo %s with new cs cache %s'
                       % (self.repo_name, cs_cache))
             self.updated_on = last_change
             self.changeset_cache = cs_cache
             Session().add(self)
             Session().commit()
         else:
             log.debug('Skipping repo:%s already with latest changes'
                       % self.repo_name)
             log.debug('changeset_cache for %s already up to date with %s'
                       % (self.repo_name, cs_cache['raw_id']))
     @property
     def tip(self):
         return self.get_changeset('tip')
     @property

0 comments (0 inline, 0 general)