kallithea Changeset - fb493f3ed4e3

Changeset - fb493f3ed4e3

Parent rev.

Child rev.

[Not reviewed]

default

0 1 0

Mads Kiilerich - 7 years ago 2018-09-30 18:29:55
mads@kiilerich.com

tests: fix vcs Hg helper functions get_user_name and get_user_email to actually use provided config_file

Running just test_get_user_name and test_get_user_email would fail when run as:
py.test kallithea/tests/vcs/test_repository.py -k test_get_user

The config file was not used at all, and the tests would only pass when
test_get_config_value had been run first and as an unfortunate side-effect had
read the same file.

1 file changed with 2 insertions and 2 deletions:

kallithea/lib/vcs/backends/hg/repository.py

0 comments (0 inline, 0 general)

kallithea/lib/vcs/backends/hg/repository.py

➞

Show inline comments

@@ @@ -613,7 +613,7 @@ class MercurialRepository(BaseRepository @@
         :param config_file: A path to file which should be used to retrieve
           configuration from (might also be a list of file paths)
         """
         username = self.get_config_value('ui', 'username')
+        username = self.get_config_value('ui', 'username', config_file=config_file)
         if username:
             return author_name(username)
         return None
@@ @@ -625,7 +625,7 @@ class MercurialRepository(BaseRepository @@
         :param config_file: A path to file which should be used to retrieve
           configuration from (might also be a list of file paths)
         """
         username = self.get_config_value('ui', 'username')
+        username = self.get_config_value('ui', 'username', config_file=config_file)
         if username:
             return author_email(username)
         return None

0 comments (0 inline, 0 general)