kallithea Changeset - fb565a8b4b4f

Changeset - fb565a8b4b4f

Parent rev.

Child rev.

[Not reviewed]

default

0 4 0

Mads Kiilerich - 9 years ago 2017-01-22 01:16:51
mads@kiilerich.com

mails: make title in header boxes slightly bolder

In my opinion, the top headers in the new mail styling seemed a bit "thin"
compared to the other headers.

4 files changed with 21 insertions and 20 deletions:

kallithea/model/notification.py

kallithea/templates/email_templates/comment.html

kallithea/templates/email_templates/header.html

kallithea/tests/models/test_dump_html_mails.ref.html

0 comments (0 inline, 0 general)

kallithea/model/notification.py

➞

Show inline comments

@@ @@ -339,6 +339,7 @@ class EmailNotificationModel(BaseModel): @@
             _kwargs.update({
                 "default_style": "%(sans_style)s;font-weight:200;font-size:14px;line-height:17px;color:%(color_text)s" % _kwargs,
                 "comment_style": "%(monospace_style)s;white-space:pre-wrap" % _kwargs,
                 "emph_style": "font-weight:600;color:%(color_emph)s" % _kwargs,
                 })
         log.debug('rendering tmpl %s with kwargs %s', base, _kwargs)

kallithea/templates/email_templates/comment.html

➞

Show inline comments

@@ @@ -8,7 +8,7 @@ @@
     <tr>
         <td width="20px"></td>
         <td>
-            <div style="font-weight:600;color:${color_emph}">${author}</div>
+            <div style="${emph_style}">${author}</div>
         </td>
         <td width="20px"></td>
     </tr>

kallithea/templates/email_templates/header.html

➞

Show inline comments

@@ @@ -10,10 +10,10 @@ @@
         <td width="30px"></td>
         <td style="${sans_style};font-size:19px;line-height:24px">
         %if link is not None:
-            <a style="text-decoration:none;color:${color_emph}" href="${link}"
+            <a style="text-decoration:none;${emph_style}" href="${link}"
                target="_blank">${title}</a>
         %else:
-            <span style="color:${color_emph}">${title}</span>
+            <span style="${emph_style}">${title}</span>
         %endif
         </td>
         <td width="30px"></td>

kallithea/tests/models/test_dump_html_mails.ref.html

➞

Show inline comments

@@ @@ -54,7 +54,7 @@ View Comment: http://comment.org @@
     <tr>
         <td width="30px"></td>
         <td style="font-family:Helvetica,Arial,sans-serif;font-size:19px;line-height:24px">
             <a style="text-decoration:none;color:#395fa0" href="http://comment.org"
+            <a style="text-decoration:none;font-weight:600;color:#395fa0" href="http://comment.org"
                target="_blank">Comment on Changeset &#34;This changeset did something clever which is hard to explain&#34;</a>
         </td>
         <td width="30px"></td>
@@ @@ -211,7 +211,7 @@ View Comment: http://comment.org @@
     <tr>
         <td width="30px"></td>
         <td style="font-family:Helvetica,Arial,sans-serif;font-size:19px;line-height:24px">
             <a style="text-decoration:none;color:#395fa0" href="http://comment.org"
+            <a style="text-decoration:none;font-weight:600;color:#395fa0" href="http://comment.org"
                target="_blank">Mention in Comment on Changeset &#34;This changeset did something clever which is hard to explain&#34;</a>
         </td>
         <td width="30px"></td>
@@ @@ -370,7 +370,7 @@ View Comment: http://comment.org @@
     <tr>
         <td width="30px"></td>
         <td style="font-family:Helvetica,Arial,sans-serif;font-size:19px;line-height:24px">
             <a style="text-decoration:none;color:#395fa0" href="http://comment.org"
+            <a style="text-decoration:none;font-weight:600;color:#395fa0" href="http://comment.org"
                target="_blank">Comment on Changeset &#34;This changeset did something clever which is hard to explain&#34;</a>
         </td>
         <td width="30px"></td>
@@ @@ -545,7 +545,7 @@ View Comment: http://comment.org @@
     <tr>
         <td width="30px"></td>
         <td style="font-family:Helvetica,Arial,sans-serif;font-size:19px;line-height:24px">
             <a style="text-decoration:none;color:#395fa0" href="http://comment.org"
+            <a style="text-decoration:none;font-weight:600;color:#395fa0" href="http://comment.org"
                target="_blank">Mention in Comment on Changeset &#34;This changeset did something clever which is hard to explain&#34;</a>
         </td>
         <td width="30px"></td>
@@ @@ -702,7 +702,7 @@ Subject: Test Message @@
     <tr>
         <td width="30px"></td>
         <td style="font-family:Helvetica,Arial,sans-serif;font-size:19px;line-height:24px">
             <span style="color:#395fa0">Message</span>
+            <span style="font-weight:600;color:#395fa0">Message</span>
         </td>
         <td width="30px"></td>
     </tr>
@@ @@ -785,7 +785,7 @@ View User Profile: http://newbie.org @@
     <tr>
         <td width="30px"></td>
         <td style="font-family:Helvetica,Arial,sans-serif;font-size:19px;line-height:24px">
             <a style="text-decoration:none;color:#395fa0" href="http://newbie.org"
+            <a style="text-decoration:none;font-weight:600;color:#395fa0" href="http://newbie.org"
                target="_blank">New User Registration</a>
         </td>
         <td width="30px"></td>
@@ @@ -925,7 +925,7 @@ View Pull Request: http://pr.org/7 @@
     <tr>
         <td width="30px"></td>
         <td style="font-family:Helvetica,Arial,sans-serif;font-size:19px;line-height:24px">
             <a style="text-decoration:none;color:#395fa0" href="http://pr.org/7"
+            <a style="text-decoration:none;font-weight:600;color:#395fa0" href="http://pr.org/7"
                target="_blank">Added as Reviewer of Pull Request #7 &#34;The Title&#34; by Requesting User (root)</a>
         </td>
         <td width="30px"></td>
@@ @@ -1098,7 +1098,7 @@ View Pull Request: http://pr.org/7 @@
     <tr>
         <td width="30px"></td>
         <td style="font-family:Helvetica,Arial,sans-serif;font-size:19px;line-height:24px">
             <a style="text-decoration:none;color:#395fa0" href="http://pr.org/7"
+            <a style="text-decoration:none;font-weight:600;color:#395fa0" href="http://pr.org/7"
                target="_blank">Mention on Pull Request #7 &#34;The Title&#34; by Requesting User (root)</a>
         </td>
         <td width="30px"></td>
@@ @@ -1266,7 +1266,7 @@ View Comment: http://pr.org/comment @@
     <tr>
         <td width="30px"></td>
         <td style="font-family:Helvetica,Arial,sans-serif;font-size:19px;line-height:24px">
             <a style="text-decoration:none;color:#395fa0" href="http://pr.org/comment"
+            <a style="text-decoration:none;font-weight:600;color:#395fa0" href="http://pr.org/comment"
                target="_blank">Comment on Pull Request #7 &#34;The Title&#34;</a>
         </td>
         <td width="30px"></td>
@@ @@ -1429,7 +1429,7 @@ View Comment: http://pr.org/comment @@
     <tr>
         <td width="30px"></td>
         <td style="font-family:Helvetica,Arial,sans-serif;font-size:19px;line-height:24px">
             <a style="text-decoration:none;color:#395fa0" href="http://pr.org/comment"
+            <a style="text-decoration:none;font-weight:600;color:#395fa0" href="http://pr.org/comment"
                target="_blank">Mention in Comment on Pull Request #7 &#34;The Title&#34;</a>
         </td>
         <td width="30px"></td>
@@ @@ -1594,7 +1594,7 @@ View Comment: http://pr.org/comment @@
     <tr>
         <td width="30px"></td>
         <td style="font-family:Helvetica,Arial,sans-serif;font-size:19px;line-height:24px">
             <a style="text-decoration:none;color:#395fa0" href="http://pr.org/comment"
+            <a style="text-decoration:none;font-weight:600;color:#395fa0" href="http://pr.org/comment"
                target="_blank">Comment on Pull Request #7 &#34;The Title&#34;</a>
         </td>
         <td width="30px"></td>
@@ @@ -1775,7 +1775,7 @@ View Comment: http://pr.org/comment @@
     <tr>
         <td width="30px"></td>
         <td style="font-family:Helvetica,Arial,sans-serif;font-size:19px;line-height:24px">
             <a style="text-decoration:none;color:#395fa0" href="http://pr.org/comment"
+            <a style="text-decoration:none;font-weight:600;color:#395fa0" href="http://pr.org/comment"
                target="_blank">Mention in Comment on Pull Request #7 &#34;The Title&#34;</a>
         </td>
         <td width="30px"></td>
@@ @@ -1956,7 +1956,7 @@ View Comment: http://pr.org/comment @@
     <tr>
         <td width="30px"></td>
         <td style="font-family:Helvetica,Arial,sans-serif;font-size:19px;line-height:24px">
             <a style="text-decoration:none;color:#395fa0" href="http://pr.org/comment"
+            <a style="text-decoration:none;font-weight:600;color:#395fa0" href="http://pr.org/comment"
                target="_blank">Pull Request #7 &#34;The Title&#34; Closed</a>
         </td>
         <td width="30px"></td>
@@ @@ -2136,7 +2136,7 @@ View Comment: http://pr.org/comment @@
     <tr>
         <td width="30px"></td>
         <td style="font-family:Helvetica,Arial,sans-serif;font-size:19px;line-height:24px">
             <a style="text-decoration:none;color:#395fa0" href="http://pr.org/comment"
+            <a style="text-decoration:none;font-weight:600;color:#395fa0" href="http://pr.org/comment"
                target="_blank">Mention in Comment on Pull Request #7 &#34;The Title&#34;</a>
         </td>
         <td width="30px"></td>
@@ @@ -2318,7 +2318,7 @@ View Comment: http://pr.org/comment @@
     <tr>
         <td width="30px"></td>
         <td style="font-family:Helvetica,Arial,sans-serif;font-size:19px;line-height:24px">
             <a style="text-decoration:none;color:#395fa0" href="http://pr.org/comment"
+            <a style="text-decoration:none;font-weight:600;color:#395fa0" href="http://pr.org/comment"
                target="_blank">Pull Request #7 &#34;The Title&#34; Closed</a>
         </td>
         <td width="30px"></td>
@@ @@ -2504,7 +2504,7 @@ View Comment: http://pr.org/comment @@
     <tr>
         <td width="30px"></td>
         <td style="font-family:Helvetica,Arial,sans-serif;font-size:19px;line-height:24px">
             <a style="text-decoration:none;color:#395fa0" href="http://pr.org/comment"
+            <a style="text-decoration:none;font-weight:600;color:#395fa0" href="http://pr.org/comment"
                target="_blank">Mention in Comment on Pull Request #7 &#34;The Title&#34;</a>
         </td>
         <td width="30px"></td>
@@ @@ -2683,7 +2683,7 @@ If it weren't you who requested the pass @@
     <tr>
         <td width="30px"></td>
         <td style="font-family:Helvetica,Arial,sans-serif;font-size:19px;line-height:24px">
             <span style="color:#395fa0">Password Reset Request</span>
+            <span style="font-weight:600;color:#395fa0">Password Reset Request</span>
         </td>
         <td width="30px"></td>
     </tr>

0 comments (0 inline, 0 general)