kallithea Changeset - ff5c4b26461a

Changeset - ff5c4b26461a

Parent rev.

Child rev.

[Not reviewed]

default

0 7 0

Mads Kiilerich - 8 years ago 2017-10-02 23:44:49
mads@kiilerich.com

templates: back out the DataTables paging disabling from c5bff92d5084

Lessons learned:
* It was not sufficiently tested with gravatars.
* It was not sufficiently tested on Chrome - Firefox seems to handle some big
pages better.
* It is unclear how big amounts of data we want to optimize for, but this
regressed too much for some cases.

7 files changed with 14 insertions and 14 deletions:

kallithea/templates/admin/my_account/my_account_repos.html

kallithea/templates/admin/my_account/my_account_watched.html

kallithea/templates/admin/repo_groups/repo_groups.html

kallithea/templates/admin/repos/repos.html

kallithea/templates/admin/user_groups/user_groups.html

kallithea/templates/admin/users/users.html

kallithea/templates/index_base.html

0 comments (0 inline, 0 general)

kallithea/templates/admin/my_account/my_account_repos.html

➞

Show inline comments

@@ @@ -16,7 +16,7 @@ @@
             {data: "action", title: ${h.jshtml(_('Action'))}, sortable: false, searchable: false}
         ],
         order: [[2, "asc"]],
         dom: '<"dataTables_left"f><"dataTables_right"i>t',
         paging: false,
         dom: '<"dataTables_left"f><"dataTables_right"ip>t',
         pageLength: 100
     });
 </script>

kallithea/templates/admin/my_account/my_account_watched.html

➞

Show inline comments

@@ @@ -15,7 +15,7 @@ @@
             {data: "last_changeset", "orderData": 3, title: ${h.jshtml(_('Tip'))}, searchable: false},
         ],
         order: [[2, "asc"]],
         dom: '<"dataTables_left"f><"dataTables_right"i>t',
         paging: false,
         dom: '<"dataTables_left"f><"dataTables_right"ip>t',
         pageLength: 100
     });
 </script>

kallithea/templates/admin/repo_groups/repo_groups.html

➞

Show inline comments

@@ @@ -43,8 +43,8 @@ @@
             {data: "action", title: ${h.jshtml(_('Action'))}, sortable: false, searchable: false}
         ],
         drawCallback: updateRowCountCallback($("#repo_group_count")),
         dom: '<"dataTables_left"f><"dataTables_right"i>t',
         paging: false,
         dom: '<"dataTables_left"f><"dataTables_right"ip>t',
         pageLength: 100
     });
 </script>

kallithea/templates/admin/repos/repos.html

➞

Show inline comments

@@ @@ -44,8 +44,8 @@ @@
             {data: "action", title: ${h.jshtml(_('Action'))}, sortable: false, searchable: false}
         ],
         drawCallback: updateRowCountCallback($("#repo_count")),
         dom: '<"dataTables_left"f><"dataTables_right"i>t',
         paging: false,
         dom: '<"dataTables_left"f><"dataTables_right"ip>t',
         pageLength: 100
     });
 </script>

kallithea/templates/admin/user_groups/user_groups.html

➞

Show inline comments

@@ @@ -43,8 +43,8 @@ @@
             {data: "action", title: ${h.jshtml(_('Action'))}, searchable: false, sortable: false}
         ],
         order: [[1, "asc"]],
         dom: '<"dataTables_left"f><"dataTables_right"i>t',
         paging: false,
         dom: '<"dataTables_left"f><"dataTables_right"ip>t',
         pageLength: 100
     });
 </script>
 </%def>

kallithea/templates/admin/users/users.html

➞

Show inline comments

@@ @@ -46,8 +46,8 @@ @@
         ],
         order: [[1, "asc"]],
         drawCallback: updateRowCountCallback($("#user_count")),
         dom: '<"dataTables_left"f><"dataTables_right"i>t',
         paging: false,
         dom: '<"dataTables_left"f><"dataTables_right"ip>t',
         pageLength: 100
     });
 </script>

kallithea/templates/index_base.html

➞

Show inline comments

@@ @@ -64,7 +64,7 @@ @@
                     {data: "atom", defaultContent: '', sortable: false}
                 ],
                 order: [[1, "asc"]],
                 dom: '<"dataTables_left"f><"dataTables_right"i>t',
                 paging: false,
                 dom: '<"dataTables_left"f><"dataTables_right"ip>t',
                 pageLength: 100
             });
       </script>

0 comments (0 inline, 0 general)