From 25e6dc6424c2e5fe01ce0cc9e7d3b5e7cabbef15 2024-03-04 22:07:14
From: Branko Majic <branko@majic.rs>
Date: 2024-03-04 22:07:14
Subject: [PATCH] MAR-192: Get rid of the dnspython requirement, and document netaddr requirement:

- This is the result of previous deprecation of using resolvable names
  for setting-up the list of allowed incoming connections when in
  maintenance mode.

---

diff --git a/docs/about.rst b/docs/about.rst
index a54ca32cc856fd6ebe5c969e53f0f07866114bac..9fb78c091c9954db639666f03b440c504f2ae2ee 100644
--- a/docs/about.rst
+++ b/docs/about.rst
@@ -17,9 +17,9 @@ supported releases, see :ref:`rolereference`.
 At the moment, the roles have been written for and tested against **Ansible
 2.9.x**.
 
-The role also utilises the ``dig`` lookup plugin which requires ``dnspython``
-package to be installed. Make sure you have the package available on controller
-machine.
+The role also utilises the ``ipv4/ipv6`` lookup plugins which require
+``netaddr`` package to be installed. Make sure you have the package
+available on controller machine.
 
 
 Why were these roles created?
diff --git a/docs/index.rst b/docs/index.rst
index 1b9511b8ab00216ca0612f522f374f47f254fde0..178030c618a428c8302aba7c24b1f6e97b288ba4 100644
--- a/docs/index.rst
+++ b/docs/index.rst
@@ -17,9 +17,9 @@ supported releases, see :ref:`rolereference`.
 At the moment, the roles have been written for and tested against **Ansible
 2.9.x**.
 
-The role also utilises the ``dig`` lookup plugin which requires ``dnspython``
-package to be installed. Make sure you have the package available on controller
-machine.
+The role also utilises the ``ipv4/ipv6`` lookup plugins which require
+``netaddr`` package to be installed. Make sure you have the package
+available on controller machine.
 
 
 Contents
diff --git a/docs/releasenotes.rst b/docs/releasenotes.rst
index 05a79953ba6f332db36416030c89cac004eb1bd3..c3fff24be08de2432395dc1d770067b6b18544f2 100644
--- a/docs/releasenotes.rst
+++ b/docs/releasenotes.rst
@@ -14,6 +14,9 @@ Debian 12 Bookworm. Some minor improvements and fixes.
 
   * Dropped support for Debian 10 (Buster).
   * Added support for Debian 12 (Bookworm).
+  * ``dnspython`` Python package is no longer required/used by any of
+    the roles.
+  * ``netaddr`` Python package is now required for using the roles.
 
 * ``backup_client`` role
 
diff --git a/requirements.in b/requirements.in
index 190917c3f2cd61b19b54f3458d6a87a03cf88846..7c588b1ba82a4cac6be32bf1b279cde2a7dbd978 100644
--- a/requirements.in
+++ b/requirements.in
@@ -1,6 +1,5 @@
 ansible~=2.9.0
 defusedxml
-dnspython
 gimmecert~=0.5.0
 molecule~=2.22.0
 netaddr
diff --git a/requirements.txt b/requirements.txt
index 459e657d6eb7373169a1ccd7dd9e0029c67f77dc..ec869ee16fdd0e6b5ecab0742da1b81f71bf2b87 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -68,8 +68,6 @@ defusedxml==0.7.1
     # via -r requirements.in
 distlib==0.3.8
     # via virtualenv
-dnspython==2.6.1
-    # via -r requirements.in
 docutils==0.20.1
     # via
     #   sphinx