From a8d7050f34317cfab6853b4f13b277fee8b20dd1 2024-09-06 12:22:42
From: Branko Majic <branko@majic.rs>
Date: 2024-09-06 12:22:42
Subject: [PATCH] MAR-218: Fix/improve reliability of mail_server tests:

- The common role has rather conservative rate limit values that
  easily get triggered when running connectivity tests in quick
  succesions.

---

diff --git a/roles/mail_server/molecule/default/group_vars/parameters-mandatory.yml b/roles/mail_server/molecule/default/group_vars/parameters-mandatory.yml
index 24be01138174a11906b8ec3ce9f3b795d0b38cda..fa9e885f55f17b49c9e5f3a23a269555d6fd43e1 100644
--- a/roles/mail_server/molecule/default/group_vars/parameters-mandatory.yml
+++ b/roles/mail_server/molecule/default/group_vars/parameters-mandatory.yml
@@ -15,3 +15,6 @@ smtp_tls_key: "{{ lookup('file', 'tests/data/x509/server/{{ inventory_hostname }
 # common
 ca_certificates:
   testca: "{{ lookup('file', 'tests/data/x509/ca/level1.cert.pem') }}"
+# Tests can run in quick succession, increase limits to avoid false negatives.
+incoming_connection_limit: 10/second
+incoming_connection_limit_burst: 60
diff --git a/roles/mail_server/molecule/default/group_vars/parameters-optional.yml b/roles/mail_server/molecule/default/group_vars/parameters-optional.yml
index 8e619365dad3c017ecd19c095055c31e769c4591..e0620c59b478447430d77838cb99e13f2d3d62af 100644
--- a/roles/mail_server/molecule/default/group_vars/parameters-optional.yml
+++ b/roles/mail_server/molecule/default/group_vars/parameters-optional.yml
@@ -39,6 +39,9 @@ release_based_smtp_allow_relay_from:
 # common
 ca_certificates:
   testca: "{{ lookup('file', 'tests/data/x509/ca/level1.cert.pem') }}"
+# Tests can run in quick succession, increase limits to avoid false negatives.
+incoming_connection_limit: 10/second
+incoming_connection_limit_burst: 60
 
 # backup_client
 enable_backup: true