majic-ansible-roles Changeset

Changeset - 3a46859c3d4c

Parent rev.

Child rev.

[Not reviewed]

0 3 0

Branko Majic (branko) - 2 months ago 2024-03-03 19:16:27
branko@majic.rs

MAR-192: Apply PAM configuration changes immediatelly for consistency purposes.

3 files changed with 12 insertions and 2 deletions:

roles/common/molecule/default/tests/test_default.py

roles/common/tasks/main.yml

roles/wsgi_website/molecule/default/tests/test_default.py

0 comments (0 inline, 0 general)

roles/common/molecule/default/tests/test_default.py

➞

Show inline comments

@@ @@ -244,13 +244,13 @@ def test_pipreqcheck_virtualenv(host): @@
     with host.sudo():
         virtualenv_activate = host.file(virtualenv_activate_path)
         assert virtualenv_activate.is_file
         assert virtualenv_activate.user == 'pipreqcheck'
         assert virtualenv_activate.group == 'pipreqcheck'
-        assert virtualenv_activate.mode == 0o644
+        assert virtualenv_activate.mode == 0o640
 def test_pipreqcheck_virtualenv_prompt(host):
     """
     Tests if Python virtual environment prompt has been set-up
     correctly.

roles/common/tasks/main.yml

➞

Show inline comments

@@ @@ -42,15 +42,25 @@ @@
   copy:
     src: "pam_umask"
     dest: "/usr/share/pam-configs/umask"
     owner: root
     group: root
     mode: 0644
   register: pam_umask
   notify:
     - Update PAM configuration
 - name: Update PAM configuration  # noqa 503
   # [503] Tasks that run when changed should likely be handlers
   #   In order to have consistent behaviour during the first and
   #   subsequent playbook runs, make sure the PAM configuration is
   #   updated immediatelly. This way any files created by commands etc
   #   should end-up with correct permissions straight away.
   command: "/usr/sbin/pam-auth-update --package"
   when: pam_umask.changed
 - name: Set login UMASK
   lineinfile:
     dest: "/etc/login.defs"
     state: present
     backrefs: true
     regexp: '^UMASK(\s+)'

roles/wsgi_website/molecule/default/tests/test_default.py

➞

Show inline comments

         assert virtualenv.mode == 0o2750
         virtualenv_activate = host.file(virtualenv_dir + "/bin/activate")
         assert virtualenv_activate.is_file
         assert virtualenv_activate.user == expected_owner
         assert virtualenv_activate.group == expected_group
-        assert virtualenv_activate.mode == 0o644
+        assert virtualenv_activate.mode == 0o640
 @pytest.mark.parametrize("project_file, expected_owner, expected_group", [
     ('/var/www/parameters-mandatory/virtualenv/.project', 'admin-parameters-mandatory', 'web-parameters-mandatory'),
     ('/var/www/parameters-optional.local/virtualenv/.project', 'admin-parameters-optional_local', 'web-parameters-optional_local'),
     ('/var/www/parameters-paste-req/virtualenv/.project', 'admin-parameters-paste-req', 'web-parameters-paste-req'),

0 comments (0 inline, 0 general)