majic-ansible-roles Changeset

Changeset - 605cdbaf9717

Parent rev.

Child rev.

[Not reviewed]

0 5 0

Branko Majic (branko) - 3 years ago 2021-01-12 23:57:38
branko@majic.rs

MAR-163: Attach noqa directives to task names (if skipping is applicable on task level) for better uniformity:

- This way the indentation of comment describing the directive can
always be on the same level everywhere (irrespective of how the rest
of task arguments are listed).

5 files changed with 13 insertions and 13 deletions:

roles/backup_client/handlers/main.yml

roles/common/handlers/main.yml

roles/mail_forwarder/handlers/main.yml

roles/mail_server/handlers/main.yml

roles/xmpp_server/tasks/main.yml

0 comments (0 inline, 0 general)

roles/backup_client/handlers/main.yml

➞

Show inline comments

@@ @@ -2,12 +2,12 @@ @@
 # @TODO: Can't use file module, since one of the files (GnuPG socket)
 #        seems to disappear in middle of operation).
 - name: Remove current keyring
   command: "rm -rf /etc/duply/main/gnupg"  # noqa 301
 - name: Remove current keyring  # noqa 301
   # [301] Commands should not change things if nothing needs doing
   #   This task is invoked only if user is very specific about requiring to
   #   run the handlers manually as a way to bring the system to consistency
   #   after interrupted runs.
   command: "rm -rf /etc/duply/main/gnupg"
   args:
     warn: false
@@ @@ -19,12 +19,12 @@ @@
     group: root
     mode: 0700
 - name: Import private keys
   command: "gpg --no-tty --homedir /etc/duply/main/gnupg --import /etc/duply/main/private_keys.asc"  # noqa 301
 - name: Import private keys  # noqa 301
   # [301] Commands should not change things if nothing needs doing
   #   This task is invoked only if user is very specific about requiring to
   #   run the handlers manually as a way to bring the system to consistency
   #   after interrupted runs.
   command: "gpg --no-tty --homedir /etc/duply/main/gnupg --import /etc/duply/main/private_keys.asc"
 - name: Import public keys
   command: "gpg --no-tty --homedir /etc/duply/main/gnupg --import /etc/duply/main/public_keys.asc"

roles/common/handlers/main.yml

➞

Show inline comments

 ---
 - name: Update PAM configuration
   command: "/usr/sbin/pam-auth-update --package"  # noqa 301
 - name: Update PAM configuration  # noqa 301
   # [301] Commands should not change things if nothing needs doing
   #   This task is invoked only if user is very specific about requiring to
   #   run the handlers manually as a way to bring the system to consistency
   #   after interrupted runs.
   command: "/usr/sbin/pam-auth-update --package"
 - name: Restart SSH
   service:
     name: ssh
     state: restarted
 - name: Update CA certificate cache
   command: "/usr/sbin/update-ca-certificates --fresh"  # noqa 301
 - name: Update CA certificate cache  # noqa 301
   # [301] Commands should not change things if nothing needs doing
   #   This task is invoked only if user is very specific about requiring to
   #   run the handlers manually as a way to bring the system to consistency
   #   after interrupted runs.
   command: "/usr/sbin/update-ca-certificates --fresh"
 - name: Restart ferm
   service:

roles/mail_forwarder/handlers/main.yml

➞

Show inline comments

 ---
 - name: Rebuild mail aliases
   command: "/usr/bin/newaliases"  # noqa 301
 - name: Rebuild mail aliases  # noqa 301
   # [301] Commands should not change things if nothing needs doing
   #   This task is invoked only if user is very specific about requiring to
   #   run the handlers manually as a way to bring the system to consistency
   #   after interrupted runs.
   command: "/usr/bin/newaliases"
 - name: Restart Postfix
   service:

roles/mail_server/handlers/main.yml

➞

Show inline comments

@@ @@ -15,9 +15,9 @@ @@
     name: clamav-milter
     state: restarted
 - name: Rebuild mail aliases
   command: /usr/bin/newaliases  # noqa 301
 - name: Rebuild mail aliases  # noqa 301
   # [301] Commands should not change things if nothing needs doing
   #   This task is invoked only if user is very specific about requiring to
   #   run the handlers manually as a way to bring the system to consistency
   #   after interrupted runs.
   command: /usr/bin/newaliases

roles/xmpp_server/tasks/main.yml

➞

Show inline comments

@@ @@ -36,11 +36,11 @@ @@
 - name: Install Lua LDAP library
   apt:
     name: lua-ldap
     state: latest  # noqa 403
     # [403] Package installs should not use latest
     #   The latest has to be used when upgrading existing systems to get
     #   the correct version of lua-ldap with support for Lua 5.2 from
     #   the backports repository.
     state: latest  # noqa 403
   notify:
     - Restart Prosody

0 comments (0 inline, 0 general)