majic-ansible-roles Changeset

Changeset - 64823e04bd4b

Parent rev.

Child rev.

[Not reviewed]

0 2 0

Branko Majic (branko) - 7 years ago 2017-06-27 18:33:29
branko@majic.rs

MAR-28: Fixed minor issues in the mail_server tasks:

- Ensure command handler is excluded from linting checks.
- Fixed modes to use leading zero.

2 files changed with 21 insertions and 15 deletions:

roles/mail_server/handlers/main.yml

roles/mail_server/tasks/main.yml

0 comments (0 inline, 0 general)

roles/mail_server/handlers/main.yml

➞

Show inline comments

@@ @@ -11,3 +11,9 @@ @@
 - name: Rebuild mail aliases
   command: /usr/bin/newaliases
   tags:
     # [ANSIBLE0012] Commands should not change things if nothing needs doing
     #   This task is invoked only if user is very specific about requiring to
     #   run the handlers manually as a way to bring the system to consistency
     #   after interrupted runs.
     - skip_ansible_lint

roles/mail_server/tasks/main.yml

➞

Show inline comments

@@ @@ -28,31 +28,31 @@ @@
 - name: Deploy SMTP TLS private key
   copy: dest="/etc/ssl/private/{{ ansible_fqdn }}_smtp.key" content="{{ smtp_tls_key }}"
-        mode=640 owner=root group=root
+        mode=0640 owner=root group=root
   notify:
     - Restart Postfix
 - name: Deploy SMTP TLS certificate
   copy: dest="/etc/ssl/certs/{{ ansible_fqdn }}_smtp.pem" content="{{ smtp_tls_certificate }}"
-        mode=644 owner=root group=root
+        mode=0644 owner=root group=root
   notify:
     - Restart Postfix
 - name: Deploy IMAP TLS private key
   copy: dest="/etc/ssl/private/{{ ansible_fqdn }}_imap.key" content="{{ imap_tls_key }}"
-        mode=640 owner=root group=root
+        mode=0640 owner=root group=root
   notify:
     - Restart Dovecot
 - name: Deploy IMAP TLS certificate
   copy: dest="/etc/ssl/certs/{{ ansible_fqdn }}_imap.pem" content="{{ imap_tls_certificate }}"
-        mode=644 owner=root group=root
+        mode=0644 owner=root group=root
   notify:
     - Restart Dovecot
 - name: Deploy configuration files for checking certificate validity via cron
   copy: content="/etc/ssl/certs/{{ ansible_fqdn }}_{{ item }}.pem" dest="/etc/check_certificate/{{ ansible_fqdn }}_{{ item }}.conf"
-        owner=root group=root mode=644
+        owner=root group=root mode=0644
   with_items:
     - smtp
     - imap
@@ @@ -65,28 +65,28 @@ @@
 - name: Configure ClamAV Milter
   copy: dest="/etc/clamav/clamav-milter.conf" src="clamav-milter.conf"
-        mode=644 owner=root group=root
+        mode=0644 owner=root group=root
   notify:
     - Restart ClamAV Milter
 - name: Set-up privileges for directories within Postfix chroot
-  file: dest="{{ item }}" mode=755 state=directory owner=root group=root
+  file: dest="{{ item }}" mode=0755 state=directory owner=root group=root
   with_items:
     - /var/spool/postfix/var
     - /var/spool/postfix/var/run
 - name: Set-up privileges for directories within Postfix chroot
-  file: dest="{{ item }}" mode=755 state=directory owner=clamav group=clamav
+  file: dest="{{ item }}" mode=0755 state=directory owner=clamav group=clamav
   with_items:
     - /var/spool/postfix/var/run/clamav
 - name: Deploy the LDAP TLS truststore in default location
   copy: content="{{ mail_ldap_tls_truststore }}" dest="/etc/ssl/certs/mail_ldap_tls_truststore.pem"
-        owner=root group=root mode=644
+        owner=root group=root mode=0644
 - name: Deploy the LDAP TLS truststore in Postfix chroot
   copy: content="{{ mail_ldap_tls_truststore }}" dest="/var/spool/postfix/etc/ssl/certs/mail_ldap_tls_truststore.pem"
-        owner=root group=root mode=644
+        owner=root group=root mode=0644
   notify:
     - Restart Postfix
@@ @@ -97,7 +97,7 @@ @@
     - Restart Postfix
 - name: Deploy Postfix configurations files for LDAP look-ups
-  template: src="{{ item }}.cf.j2" dest="/etc/postfix/{{ item }}.cf" owner=root group=postfix mode=640
+  template: src="{{ item }}.cf.j2" dest="/etc/postfix/{{ item }}.cf" owner=root group=postfix mode=0640
   with_items:
     - ldap-virtual-alias-maps
     - ldap-virtual-mailbox-domains
@@ @@ -133,18 +133,18 @@ @@
     - Restart Dovecot
 - name: Deploy Dovecot configuration file with overrides
-  template: src="99-local.conf.j2" dest="/etc/dovecot/conf.d/99-local.conf" owner=root group=root mode=644
+  template: src="99-local.conf.j2" dest="/etc/dovecot/conf.d/99-local.conf" owner=root group=root mode=0644
   notify:
     - Restart Dovecot
 - name: Deploy Dovecot configuration file for LDAP look-ups
-  template: src="dovecot-ldap.conf.ext.j2" dest="/etc/dovecot/dovecot-ldap.conf.ext" owner=root group=root mode=600
+  template: src="dovecot-ldap.conf.ext.j2" dest="/etc/dovecot/dovecot-ldap.conf.ext" owner=root group=root mode=0600
   notify:
     - Restart Dovecot
 - name: Deploy Postifx master process configuration
   template: src="master.cf.j2" dest="/etc/postfix/master.cf"
-            owner=root group=root mode=644
+            owner=root group=root mode=0644
   notify:
     - Restart Postfix
@@ @@ -188,7 +188,7 @@ @@
   service: name=dovecot state=started
 - name: Deploy firewall configuration for mail server
-  copy: src="ferm_mail.conf" dest="/etc/ferm/conf.d/20-mail.conf" owner=root group=root mode=640
+  copy: src="ferm_mail.conf" dest="/etc/ferm/conf.d/20-mail.conf" owner=root group=root mode=0640
   notify:
     - Restart ferm

0 comments (0 inline, 0 general)