majic-ansible-roles Changeset

Changeset - 8a6ebeaabb26

Parent rev.

Child rev.

[Not reviewed]

0 3 0

Branko Majic (branko) - 7 years ago 2017-08-21 20:13:42
branko@majic.rs

MAR-125: Eliminated a couple of warnings:

- Use the file module when cleaning-up the /etc/duply/main/gnupg directory.
- Mark the bind_password in m_ldap_entry and m_ldap_permissions as no_log
parameters.

3 files changed with 11 insertions and 9 deletions:

roles/backup_client/handlers/main.yml

roles/ldap_server/library/m_ldap_entry.py

roles/ldap_server/library/m_ldap_permissions.py

0 comments (0 inline, 0 general)

roles/backup_client/handlers/main.yml

➞

Show inline comments

 ---
 - name: Clean-up GnuPG keyring for import of new keys
   shell: "rm -f /etc/duply/main/gnupg/*"
   tags:
     # [ANSIBLE0007] rm used in place of argument state=absent to file module
     #   This task is invoked only if user is very specific about requiring to
     #   run the handlers manually as a way to bring the system to consistency
     #   after interrupted runs.
     - skip_ansible_lint
   file:
     path: "/etc/duply/main/gnupg"
     state: "{{ item }}"
     owner: root
     group: root
     mode: 0700
   with_items:
     - absent
     - directory
 - name: Import private keys
   command: "{{ gnupg_binary }} --homedir /etc/duply/main/gnupg --import /etc/duply/main/private_keys.asc"

roles/ldap_server/library/m_ldap_entry.py

➞

Show inline comments

@@ @@ -342,7 +342,7 @@ def main(): @@
             state=dict(required=False, choices=["present", "absent", "append", "replace"], default="present"),
             server_uri=dict(required=False, default="ldapi:///"),
             bind_dn=dict(required=False, default=None),
             bind_password=dict(required=False),
+            bind_password=dict(required=False, no_log=True),
             attributes=dict(required=False, type='dict', default=None),
             ),
         check_invalid_arguments=False

roles/ldap_server/library/m_ldap_permissions.py

➞

Show inline comments

@@ @@ -267,7 +267,7 @@ def main(): @@
             rules=dict(required=True, type='list'),
             server_uri=dict(required=False, default="ldapi:///"),
             bind_dn=dict(required=False, default=None),
             bind_password=dict(required=False)
+            bind_password=dict(required=False, no_log=True)
+            )
+        )

0 comments (0 inline, 0 general)