majic-ansible-roles Changeset

Changeset - 91b633aba998

Parent rev.

Child rev.

[Not reviewed]

0 6 1

Branko Majic (branko) - 6 years ago 2018-05-27 20:31:05
branko@majic.rs

MAR-129: Fixed linting in database_server and its tests and moved test variables into group_vars.

7 files changed with 17 insertions and 13 deletions:

roles/database_server/molecule/default/create.yml

roles/database_server/molecule/default/destroy.yml

roles/database_server/molecule/default/group_vars/parameters-mandatory.yml

roles/database_server/molecule/default/molecule.yml

roles/database_server/molecule/default/playbook.yml

roles/database_server/molecule/default/prepare.yml

roles/database_server/tasks/main.yml

0 comments (0 inline, 0 general)

roles/database_server/molecule/default/create.yml

➞

Show inline comments

@@ @@ -2,7 +2,7 @@ @@
 - name: Create
   hosts: localhost
   connection: local
-  gather_facts: False
+  gather_facts: false
   no_log: "{{ not lookup('env', 'MOLECULE_DEBUG') | bool }}"
   vars:
     molecule_file: "{{ lookup('env', 'MOLECULE_FILE') }}"

roles/database_server/molecule/default/destroy.yml

➞

Show inline comments

@@ @@ -3,7 +3,7 @@ @@
 - name: Destroy
   hosts: localhost
   connection: local
-  gather_facts: False
+  gather_facts: false
   no_log: "{{ not lookup('env', 'MOLECULE_DEBUG') | bool }}"
   vars:
     molecule_file: "{{ lookup('env', 'MOLECULE_FILE') }}"

roles/database_server/molecule/default/group_vars/parameters-mandatory.yml

➞

Show inline comments

		new file 100644
		---

		db_root_password: "root_password"

roles/database_server/molecule/default/molecule.yml

➞

Show inline comments

@@ @@ -9,6 +9,8 @@ driver: @@
 lint:
   name: yamllint
   options:
     config-file: ../../.yamllint.yml
 platforms:

roles/database_server/molecule/default/playbook.yml

➞

Show inline comments

 ---
 - hosts: parameters-mandatory
-  become: yes
+  become: true
   roles:
     - role: database_server
       db_root_password: "root_password"
     - database_server

roles/database_server/molecule/default/prepare.yml

➞

Show inline comments

@@ @@ -2,18 +2,18 @@ @@
 - name: Prepare
   hosts: all
-  gather_facts: False
+  gather_facts: false
   tasks:
     - name: Install python for Ansible
       raw: test -e /usr/bin/python || (apt -y update && apt install -y python-minimal)
       become: True
       changed_when: False
       become: true
       changed_when: false
 - hosts: all
-  become: yes
+  become: true
   tasks:
     - name: Update all caches to avoid errors due to missing remote archives
       apt:
         update_cache: yes
       changed_when: False
         update_cache: true
       changed_when: false

roles/database_server/tasks/main.yml

➞

Show inline comments

@@ @@ -3,7 +3,7 @@ @@
 - name: Install MariaDB
   apt:
     name: "{{ item }}"
-    state: installed
+    state: present
   with_items:
     - mariadb-client
     - mariadb-server
@@ @@ -21,7 +21,7 @@ @@
 - name: Set password for the root database user
   mysql_user:
-    check_implicit_admin: yes
+    check_implicit_admin: true
     name: root
     password: "{{ db_root_password }}"

0 comments (0 inline, 0 general)