Changeset - a3d247bb2e09
Parent rev.
Child rev.
[Not reviewed]
0 10 0
Branko Majic (branko) - 7 months ago 2024-09-03 13:09:27
branko@majic.rs
MAR-218: Update noqa directives for ansible-lint to use text tags:

- Numeric tagging is deprecated.
10 files changed with 28 insertions and 28 deletions:
roles/backup_client/handlers/main.yml
4
4
roles/common/handlers/main.yml
4
4
roles/common/tasks/main.yml
4
4
roles/database_server/tasks/main.yml
2
2
roles/ldap_server/tasks/main.yml
2
2
roles/mail_forwarder/handlers/main.yml
2
2
roles/mail_forwarder/tasks/main.yml
4
4
roles/mail_server/handlers/main.yml
2
2
roles/wsgi_website/tasks/main.yml
2
2
roles/xmpp_server/tasks/main.yml
2
2
0 comments (0 inline, 0 general) First comment
roles/backup_client/handlers/main.yml
➞
Show inline comments
 
@@ -2,8 +2,8 @@
 

			




	
	
	
		
 
# @TODO: Can't use file module, since one of the files (GnuPG socket)

			




	
	
	
		
 
#        seems to disappear in middle of operation).

			




	
	
	
		
 
- name: Remove current keyring  # noqa 301

			




	
	
	
		
 
  # [301] Commands should not change things if nothing needs doing

			




	
	
	
		
 
- name: Remove current keyring  # noqa no-changed-when

			




	
	
	
		
 
  # [no-changed-when] Commands should not change things if nothing needs doing

			




	
	
	
		
 
  #   This task is invoked only if user is very specific about requiring to

			




	
	
	
		
 
  #   run the handlers manually as a way to bring the system to consistency

			




	
	
	
		
 
  #   after interrupted runs.

			




	
	
		
 
@@ -17,8 +17,8 @@

			




	
	
	
		
 
    group: root

			




	
	
	
		
 
    mode: 0700

			




	
	
	
		
 

			




	
	
	
		
 
- name: Import private keys  # noqa 301

			




	
	
	
		
 
  # [301] Commands should not change things if nothing needs doing

			




	
	
	
		
 
- name: Import private keys  # noqa no-changed-when

			




	
	
	
		
 
  # [no-changed-when] Commands should not change things if nothing needs doing

			




	
	
	
		
 
  #   This task is invoked only if user is very specific about requiring to

			




	
	
	
		
 
  #   run the handlers manually as a way to bring the system to consistency

			




	
	
	
		
 
  #   after interrupted runs.

			




        

    


    
    

    

        

                

                    roles/common/handlers/main.yml
                

                

                  
                      
                        

                      ➞

                      
                        
                  

                  
                      
                  
                      
                  
                      
                  
                      
                  
                  
                

                

                    Show inline comments
                    
                

        

        

            



	
	
	
		
 
---

			




	
	
	
		
 

			




	
	
	
		
 
- name: Update PAM configuration  # noqa 301

			




	
	
	
		
 
  # [301] Commands should not change things if nothing needs doing

			




	
	
	
		
 
- name: Update PAM configuration  # noqa no-changed-when

			




	
	
	
		
 
  # [no-changed-when] Commands should not change things if nothing needs doing

			




	
	
	
		
 
  #   This task is invoked only if user is very specific about requiring to

			




	
	
	
		
 
  #   run the handlers manually as a way to bring the system to consistency

			




	
	
	
		
 
  #   after interrupted runs.

			




	
	
		
 
@@ -12,8 +12,8 @@

			




	
	
	
		
 
    name: ssh

			




	
	
	
		
 
    state: restarted

			




	
	
	
		
 

			




	
	
	
		
 
- name: Update CA certificate cache  # noqa 301

			




	
	
	
		
 
  # [301] Commands should not change things if nothing needs doing

			




	
	
	
		
 
- name: Update CA certificate cache  # noqa no-changed-when

			




	
	
	
		
 
  # [no-changed-when] Commands should not change things if nothing needs doing

			




	
	
	
		
 
  #   This task is invoked only if user is very specific about requiring to

			




	
	
	
		
 
  #   run the handlers manually as a way to bring the system to consistency

			




	
	
	
		
 
  #   after interrupted runs.

			




        

    


    
    

    

        

                

                    roles/common/tasks/main.yml
                

                

                  
                      
                        

                      ➞

                      
                        
                  

                  
                      
                  
                      
                  
                      
                  
                      
                  
                  
                

                

                    Show inline comments
                    
                

        

        

            



	
	
		
 
@@ -49,8 +49,8 @@

			




	
	
	
		
 
  notify:

			




	
	
	
		
 
    - Update PAM configuration

			




	
	
	
		
 

			




	
	
	
		
 
- name: Update PAM configuration  # noqa 503

			




	
	
	
		
 
  # [503] Tasks that run when changed should likely be handlers

			




	
	
	
		
 
- name: Update PAM configuration  # noqa no-handler

			




	
	
	
		
 
  # [no-handler] Tasks that run when changed should likely be handlers

			




	
	
	
		
 
  #   In order to have consistent behaviour during the first and

			




	
	
	
		
 
  #   subsequent playbook runs, make sure the PAM configuration is

			




	
	
	
		
 
  #   updated immediatelly. This way any files created by commands etc

			




	
	
		
 
@@ -204,8 +204,8 @@

			




	
	
	
		
 
  with_dict: "{{ ca_certificates }}"

			




	
	
	
		
 
  register: deploy_ca_certificates_result

			




	
	
	
		
 

			




	
	
	
		
 
- name: Update CA certificate cache  # noqa 503

			




	
	
	
		
 
  # [503] Tasks that run when changed should likely be handlers

			




	
	
	
		
 
- name: Update CA certificate cache  # noqa no-handler

			




	
	
	
		
 
  # [no-handler] Tasks that run when changed should likely be handlers

			




	
	
	
		
 
  #   CA certificate cache must be updated immediatelly in order for

			




	
	
	
		
 
  #   applications depending on deployed CA certificates can use them to

			




	
	
	
		
 
  #   validate server/client certificates.

			




        

    


    
    

    

        

                

                    roles/database_server/tasks/main.yml
                

                

                  
                      
                        

                      ➞

                      
                        
                  

                  
                      
                  
                      
                  
                      
                  
                      
                  
                  
                

                

                    Show inline comments
                    
                

        

        

            



	
	
		
 
@@ -23,8 +23,8 @@

			




	
	
	
		
 
    mode: 0644

			




	
	
	
		
 
  register: mariadb_utf8_configuration

			




	
	
	
		
 

			




	
	
	
		
 
- name: Restart MariaDB in order to use UTF-8 as default character set  # noqa 503

			




	
	
	
		
 
  # [503] Tasks that run when changed should likely be handlers

			




	
	
	
		
 
- name: Restart MariaDB in order to use UTF-8 as default character set  # noqa no-handler

			




	
	
	
		
 
  # [no-handler] Tasks that run when changed should likely be handlers

			




	
	
	
		
 
  #   UTF-8 configuration must be applied immediatelly in order to ensure that

			




	
	
	
		
 
  #   subsequent tasks that create databases will end-up with correct (UTF-8)

			




	
	
	
		
 
  #   encoding. Otherwise they will be created using default latin1.

			




        

    


    
    

    

        

                

                    roles/ldap_server/tasks/main.yml
                

                

                  
                      
                        

                      ➞

                      
                        
                  

                  
                      
                  
                      
                  
                      
                  
                      
                  
                  
                

                

                    Show inline comments
                    
                

        

        

            



	
	
		
 
@@ -26,8 +26,8 @@

			




	
	
	
		
 
    groups: ssl-cert

			




	
	
	
		
 
  register: openldap_in_ssl_cert

			




	
	
	
		
 

			




	
	
	
		
 
- name: Restart slapd if group membership has changed (apply immediatelly)  # noqa 503

			




	
	
	
		
 
  # [503] Tasks that run when changed should likely be handlers

			




	
	
	
		
 
- name: Restart slapd if group membership has changed (apply immediatelly)  # noqa no-handler

			




	
	
	
		
 
  # [no-handler] Tasks that run when changed should likely be handlers

			




	
	
	
		
 
  #   In order to be able to change LDAP server TLS configuration, it must be

			




	
	
	
		
 
  #   able to read both the private key and certificate. Therefore we need to

			




	
	
	
		
 
  #   immediatelly restart (since configuration is done live on the server.

			




        

    


    
    

    

        

                

                    roles/mail_forwarder/handlers/main.yml
                

                

                  
                      
                        

                      ➞

                      
                        
                  

                  
                      
                  
                      
                  
                      
                  
                      
                  
                  
                

                

                    Show inline comments
                    
                

        

        

            



	
	
	
		
 
---

			




	
	
	
		
 

			




	
	
	
		
 
- name: Rebuild mail aliases  # noqa 301

			




	
	
	
		
 
  # [301] Commands should not change things if nothing needs doing

			




	
	
	
		
 
- name: Rebuild mail aliases  # noqa no-changed-when

			




	
	
	
		
 
  # [no-changed-when] Commands should not change things if nothing needs doing

			




	
	
	
		
 
  #   This task is invoked only if user is very specific about requiring to

			




	
	
	
		
 
  #   run the handlers manually as a way to bring the system to consistency

			




	
	
	
		
 
  #   after interrupted runs.

			




        

    


    
    

    

        

                

                    roles/mail_forwarder/tasks/main.yml
                

                

                  
                      
                        

                      ➞

                      
                        
                  

                  
                      
                  
                      
                  
                      
                  
                      
                  
                  
                

                

                    Show inline comments
                    
                

        

        

            



	
	
		
 
@@ -71,8 +71,8 @@

			




	
	
	
		
 
    enabled: true

			




	
	
	
		
 

			




	
	
	
		
 
- name: Retrieve IPv4 addresses of SMTP relay host

			




	
	
	
		
 
  shell: "getent ahostsv4 '{{ smtp_relay_host }}' | awk '{ print $1 }' | sort -u"  # noqa 306

			




	
	
	
		
 
  # [306] Shells that use pipes should set the pipefail option

			




	
	
	
		
 
  shell: "getent ahostsv4 '{{ smtp_relay_host }}' | awk '{ print $1 }' | sort -u"  # noqa risky-shell-pipe

			




	
	
	
		
 
  # [risky-shell-pipe] Shells that use pipes should set the pipefail option

			




	
	
	
		
 
  #   The getent ahostsv4 command has non-zero exit code if the

			




	
	
	
		
 
  #   supplies name cannot be resolved. However, that is a valid

			




	
	
	
		
 
  #   use-case for extracting this information. It effectively means

			




	
	
		
 
@@ -82,8 +82,8 @@

			




	
	
	
		
 
  register: smtp_relay_host_ipv4

			




	
	
	
		
 

			




	
	
	
		
 
- name: Retrieve IPv6 addresses of SMTP relay host

			




	
	
	
		
 
  shell: "getent ahostsv6 '{{ smtp_relay_host }}' | awk '{ print $1 }' | grep -v '^::ffff:' | sort -u"  # noqa 306

			




	
	
	
		
 
  # [306] Shells that use pipes should set the pipefail option

			




	
	
	
		
 
  shell: "getent ahostsv6 '{{ smtp_relay_host }}' | awk '{ print $1 }' | grep -v '^::ffff:' | sort -u"  # noqa risky-shell-pipe

			




	
	
	
		
 
  # [risky-shell-pipe] Shells that use pipes should set the pipefail option

			




	
	
	
		
 
  #   The getent ahostsv6 command has non-zero exit code if the

			




	
	
	
		
 
  #   supplies name cannot be resolved. However, that is a valid

			




	
	
	
		
 
  #   use-case for extracting this information. It effectively means

			




        

    


    
    

    

        

                

                    roles/mail_server/handlers/main.yml
                

                

                  
                      
                        

                      ➞

                      
                        
                  

                  
                      
                  
                      
                  
                      
                  
                      
                  
                  
                

                

                    Show inline comments
                    
                

        

        

            



	
	
		
 
@@ -15,8 +15,8 @@

			




	
	
	
		
 
    name: clamav-milter

			




	
	
	
		
 
    state: restarted

			




	
	
	
		
 

			




	
	
	
		
 
- name: Rebuild mail aliases  # noqa 301

			




	
	
	
		
 
  # [301] Commands should not change things if nothing needs doing

			




	
	
	
		
 
- name: Rebuild mail aliases  # noqa no-changed-when

			




	
	
	
		
 
  # [no-changed-when] Commands should not change things if nothing needs doing

			




	
	
	
		
 
  #   This task is invoked only if user is very specific about requiring to

			




	
	
	
		
 
  #   run the handlers manually as a way to bring the system to consistency

			




	
	
	
		
 
  #   after interrupted runs.

			




        

    


    
    

    

        

                

                    roles/wsgi_website/tasks/main.yml
                

                

                  
                      
                        

                      ➞

                      
                        
                  

                  
                      
                  
                      
                  
                      
                  
                      
                  
                  
                

                

                    Show inline comments
                    
                

        

        

            



	
	
		
 
@@ -295,8 +295,8 @@

			




	
	
	
		
 
  tags:

			




	
	
	
		
 
    - handlers

			




	
	
	
		
 

			




	
	
	
		
 
- name: Add service to list of WSGI services to restart  # noqa 503

			




	
	
	
		
 
  # [503] Tasks that run when changed should likely be handlers

			




	
	
	
		
 
- name: Add service to list of WSGI services to restart  # noqa no-handler

			




	
	
	
		
 
  # [no-handler] Tasks that run when changed should likely be handlers

			




	
	
	
		
 
  #   This specific task is used in order to work around inability of Ansible

			




	
	
	
		
 
  #   to provide properly parametrised handlers for reusable roles.

			




	
	
	
		
 
  set_fact:

			




        

    


    
    

    

        

                

                    roles/xmpp_server/tasks/main.yml
                

                

                  
                      
                        

                      ➞

                      
                        
                  

                  
                      
                  
                      
                  
                      
                  
                      
                  
                  
                

                

                    Show inline comments
                    
                

        

        

            



	
	
		
 
@@ -12,8 +12,8 @@

			




	
	
	
		
 
    mode: 0644

			




	
	
	
		
 
  register: backports_repository_configuration

			




	
	
	
		
 

			




	
	
	
		
 
- name: Update apt cache if backports repository configuration changed (for immediate use)  # noqa 503

			




	
	
	
		
 
  # [503] Tasks that run when changed should likely be handlers

			




	
	
	
		
 
- name: Update apt cache if backports repository configuration changed (for immediate use)  # noqa no-handler

			




	
	
	
		
 
  # [no-handler] Tasks that run when changed should likely be handlers

			




	
	
	
		
 
  #   Since apt_repository module is not reliable (does not deploy

			




	
	
	
		
 
  #   change when changing distro version etc), we have to use

			




	
	
	
		
 
  #   template instead, but this also means we need to trigger the apt

			




        

    



    


    



    



      

      





    
    0 comments (0 inline, 0 general)
    First comment





    


  

  

      

      

          

            You need to be logged in to comment. Login now
          

      

      

      
      

      

  







  


    




    








    
        
    
    
        This site is powered by
            Kallithea 0.7.99,
        which is
        © 2010–2024 by various authors & licensed under GPLv3.