majic-ansible-roles Changeset

Changeset - b34547147a36

Parent rev.

Child rev.

[Not reviewed]

0 1 0

Branko Majic (branko) - 3 months ago 2024-02-10 11:10:11
branko@majic.rs

MAR-193: Fix some linting errors reported by shellcheck.

1 file changed with 5 insertions and 4 deletions:

roles/common/files/pip_check_requirements_upgrades.sh

0 comments (0 inline, 0 general)

roles/common/files/pip_check_requirements_upgrades.sh

➞

Show inline comments

@@ @@ -101,13 +101,13 @@ $program @@
 EOF
+}
 # Set-up colours for message printing if we're not piping and terminal is
 # capable of outputting the colors.
 _color_terminal=$(tput colors 2>&1)
-if [[ -t 1 ]] && (( ${_color_terminal} > 0 )); then
 if [[ -t 1 ]] && (( _color_terminal > 0 )); then
     _text_bold=$(tput bold)
     _text_white=$(tput setaf 7)
     _text_blue=$(tput setaf 6)
     _text_green=$(tput setaf 2)
     _text_yellow=$(tput setaf 3)
     _text_red=$(tput setaf 1)
@@ @@ -176,13 +176,13 @@ while getopts "V:qdvh" opt; do @@
            exit "$SUCCESS";;
         *) usage
            exit "$ERROR_ARGUMENTS";;
     esac
 done
 i=$OPTIND
-shift $(($i-1))
+shift $(( i-1 ))
 if [[ ${#@} == 0 ]]; then
     error "Must pass configuration directory."
     usage
     exit "$ERROR_ARGUMENTS"
@@ @@ -199,12 +199,13 @@ fi @@
 if [[ -n $virtualenv && ! -f $virtualenv/bin/activate ]]; then
     error "Invalid virtual environment specified: $virtualenv"
     exit "$ERROR_ARGUMENTS"
 fi
 # Activate the virtual environment if it was specified.
 # shellcheck disable=SC1090 # no point in validating external script
 [[ -n $virtualenv ]] && source "$virtualenv/bin/activate"
 # Verify pip-compile is available.
 if ! which pip-compile >/dev/null 2>&1; then
     error "Could not find command pip-compile from packagep pip-tools. Package might not be available in the virtual environment."
     exit "$ERROR_PIP_TOOLS_MISSING"
@@ @@ -268,14 +269,14 @@ for environment in "$config_dir"/*; do @@
         fi
         # Clean up the new requirements to contain only package
         # versioning information.
         new=$(echo "$new" | sed -e 's/[[:blank:]]*#.*//' | grep -v "^$" | sort -u)
         debug "Current requirements:\n$(echo "$current")"
         debug "New requirements:\n$(echo "$new")"
         debug "Current requirements:\n$current\n"
         debug "New requirements:\n$new\n"
         # Run diff, storing the output and result.
         # This is using Bash process substitution, which helps avoid
         # creating and keeping track of temporary files (since diff
         # must be fed with two input files). E.g. the <() will
         # essentially be path to a Bash-created/managed temporary

0 comments (0 inline, 0 general)