kallithea Changeset - 4086efa27652

Changeset - 4086efa27652

Parent rev.

Child rev.

[Not reviewed]

default

0 2 0

Thomas De Schampheleire - 8 years ago 2018-02-07 09:24:14
thomas.de_schampheleire@nokia.com

tests: notification: clarify that cs_target_repo is a URL

In analogy with the fake URLs used for pullrequest notification testing, use
an URL for cs_target_repo. When testing the resulting HTML in a real email
client, it will become obvious that the mail client transforms URLs to
something clickable, regardless of any present <a> tag.

2 files changed with 9 insertions and 9 deletions:

kallithea/tests/models/test_dump_html_mails.ref.html

kallithea/tests/models/test_notifications.py

0 comments (0 inline, 0 general)

kallithea/tests/models/test_dump_html_mails.ref.html

➞

Show inline comments

@@ @@ -19,13 +19,13 @@ Opinionated User (jsmith): @@
 This is the new comment.
  - and here it ends indented.
 Changeset on repo_target branch brunch:
+Changeset on http://example.com/repo_target branch brunch:
 "This changeset did something clever which is hard to explain" by u2 u3 (u2).
 View Comment: http://comment.org
 </pre>
 <hr/>
@@ @@ -109,13 +109,13 @@ View Comment: http://comment.org @@
     </tr>
     <tr>
         <td>
             <div>
                 Changeset on
                 <a style="color:#395fa0;text-decoration:none"
                    href="repo_target">repo_target</a>
+                   href="http://example.com/repo_target">http://example.com/repo_target</a>
                 branch
                 <span style="color:#395fa0">brunch</span>:
             </div>
             <div>
                 "<a style="color:#395fa0;text-decoration:none"
                    href="http://changeset.com">This changeset did something clever which is hard to explain</a>"
@@ @@ -178,13 +178,13 @@ Opinionated User (jsmith): @@
 This is the new comment.
  - and here it ends indented.
 Changeset on repo_target branch brunch:
+Changeset on http://example.com/repo_target branch brunch:
 "This changeset did something clever which is hard to explain" by u2 u3 (u2).
 View Comment: http://comment.org
 </pre>
 <hr/>
@@ @@ -268,13 +268,13 @@ View Comment: http://comment.org @@
     </tr>
     <tr>
         <td>
             <div>
                 Changeset on
                 <a style="color:#395fa0;text-decoration:none"
                    href="repo_target">repo_target</a>
+                   href="http://example.com/repo_target">http://example.com/repo_target</a>
                 branch
                 <span style="color:#395fa0">brunch</span>:
             </div>
             <div>
                 "<a style="color:#395fa0;text-decoration:none"
                    href="http://changeset.com">This changeset did something clever which is hard to explain</a>"
@@ @@ -339,13 +339,13 @@ Status change: Approved @@
 This is the new comment.
  - and here it ends indented.
 Changeset on repo_target branch brunch:
+Changeset on http://example.com/repo_target branch brunch:
 "This changeset did something clever which is hard to explain" by u2 u3 (u2).
 View Comment: http://comment.org
 </pre>
 <hr/>
@@ @@ -445,13 +445,13 @@ View Comment: http://comment.org @@
     </tr>
     <tr>
         <td>
             <div>
                 Changeset on
                 <a style="color:#395fa0;text-decoration:none"
                    href="repo_target">repo_target</a>
+                   href="http://example.com/repo_target">http://example.com/repo_target</a>
                 branch
                 <span style="color:#395fa0">brunch</span>:
             </div>
             <div>
                 "<a style="color:#395fa0;text-decoration:none"
                    href="http://changeset.com">This changeset did something clever which is hard to explain</a>"
@@ @@ -516,13 +516,13 @@ Status change: Approved @@
 This is the new comment.
  - and here it ends indented.
 Changeset on repo_target branch brunch:
+Changeset on http://example.com/repo_target branch brunch:
 "This changeset did something clever which is hard to explain" by u2 u3 (u2).
 View Comment: http://comment.org
 </pre>
 <hr/>
@@ @@ -622,13 +622,13 @@ View Comment: http://comment.org @@
     </tr>
     <tr>
         <td>
             <div>
                 Changeset on
                 <a style="color:#395fa0;text-decoration:none"
                    href="repo_target">repo_target</a>
+                   href="http://example.com/repo_target">http://example.com/repo_target</a>
                 branch
                 <span style="color:#395fa0">brunch</span>:
             </div>
             <div>
                 "<a style="color:#395fa0;text-decoration:none"
                    href="http://changeset.com">This changeset did something clever which is hard to explain</a>"

kallithea/tests/models/test_notifications.py

➞

Show inline comments

@@ @@ -217,13 +217,13 @@ class TestNotifications(TestController): @@
                         cs_comment_user='Opinionated User (jsmith)',
                         cs_comment_url='http://comment.org',
                         is_mention=[False, True],
                         message='This changeset did something clever which is hard to explain',
                         message_short='This changeset did something cl...',
                         status_change=[None, 'Approved'],
                         cs_target_repo='repo_target',
+                        cs_target_repo='http://example.com/repo_target',
                         cs_url='http://changeset.com',
                         cs_author=User.get(self.u2))),
                     (Notification.TYPE_MESSAGE,
                      u'This is the body of the test message\n - nothing interesting here except indentation.',
                      dict()),
                     #(Notification.TYPE_MENTION, '$body', None), # not used

0 comments (0 inline, 0 general)