kallithea Changeset - 52a10832bbb0

Changeset - 52a10832bbb0

Parent rev.

Child rev.

[Not reviewed]

default

0 1 0

Mads Kiilerich - 10 years ago 2016-05-04 01:18:25
madski@unity3d.com

pullrequests: reword the grumpy "Rejected" to the more neutral and factual "Not approved"

"Rejecting" could be considered rude and some reviewers were thus reluctant to
use it. Rewording it might give reviewers a voice to better express their
feelings.

1 file changed with 2 insertions and 2 deletions:

kallithea/model/db.py

0 comments (0 inline, 0 general)

kallithea/model/db.py

➞

Show inline comments

@@ @@ -2229,13 +2229,13 @@ class ChangesetStatus(Base, BaseModel): @@
     STATUS_NOT_REVIEWED = DEFAULT = 'not_reviewed'
     STATUS_APPROVED = 'approved'
     STATUS_REJECTED = 'rejected'
+    STATUS_REJECTED = 'rejected' # is shown as "Not approved" - TODO: change database content / scheme
     STATUS_UNDER_REVIEW = 'under_review'
     STATUSES = [
         (STATUS_NOT_REVIEWED, _("Not reviewed")),  # (no icon) and default
         (STATUS_APPROVED, _("Approved")),
-        (STATUS_REJECTED, _("Rejected")),
+        (STATUS_REJECTED, _("Not approved")),
         (STATUS_UNDER_REVIEW, _("Under review")),
+    ]
     STATUSES_DICT = dict(STATUSES)

0 comments (0 inline, 0 general)