kallithea Changeset - 588c556aa00b

Changeset - 588c556aa00b

Parent rev.

Child rev.

[Not reviewed]

default

0 1 0

Søren Løvborg - 9 years ago 2017-02-23 16:24:24
sorenl@unity3d.com

comments: for PR comments, link directly to comment on PR page

Comments with approval changes made in the context of PRs also show up
on the individual PR changesets, and currently link to the (top of the)
PR page. If the user wants to see the surrounding comments, it can be
difficult to find the comment.

This change makes the link go to the comment anchor on the PR page, so
the user immediately sees the relevant comment thread. The PR metadata
is still readily available (by scrolling up or pressing "Home").

1 file changed with 1 insertions and 1 deletions:

kallithea/templates/changeset/changeset_file_comment.html

0 comments (0 inline, 0 general)

kallithea/templates/changeset/changeset_file_comment.html

➞

Show inline comments

@@ @@ -17,7 +17,7 @@ @@
               ${h.age(co.modified_at)}
               %if co.pull_request:
                 ${_('on pull request')}
-                <a href="${co.pull_request.url()}">"${co.pull_request.title or _("No title")}"</a>
                 <a href="${co.url()}">"${co.pull_request.title or _("No title")}"</a>
               %else:
                 ${_('on this changeset')}
               %endif

0 comments (0 inline, 0 general)