Files
@ 0452c45a546c
Branch filter:
Location: kallithea/docs/api/models.rst
0452c45a546c
632 B
text/prs.fallenstein.rst
pullrequests: fix broken "new PR iteration" handling of ancestor changes
An earlier refactor (5d60c9a391cd) flubbed this code and accidentally
assumed the most recent common ancestor would not change when iterating,
which is of course only the case when there are no merges from 'other' to
'org' among the new revisions.
This was not only not caught during manual testing (nor review), but
neither did the test suite test this. That has now also been rectified.
An earlier refactor (5d60c9a391cd) flubbed this code and accidentally
assumed the most recent common ancestor would not change when iterating,
which is of course only the case when there are no merges from 'other' to
'org' among the new revisions.
This was not only not caught during manual testing (nor review), but
neither did the test suite test this. That has now also been rectified.