kallithea Files · rhodecode/templates/branches/branches

Files @ 260a7a01b054

Branch filter:

Location: kallithea/rhodecode/templates/branches/branches_data.html

260a7a01b054 2.5 KiB text/html Show Annotation Show as Raw Download as Raw

Mads Kiilerich

follow Python conventions for boolean values

True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.

If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.

%if c.repo_branches:
   <div id="table_wrap" class="yui-skin-sam">
    <table id="branches_data">
      <thead>
        <tr>
            <th class="left">${_('Name')}</th>
            <th class="left">${_('Date')}</th>
            <th class="left">${_('Author')}</th>
            <th class="left">${_('Revision')}</th>
            <th class="left">${_('Compare')}</th>
        </tr>
      </thead>
        %for cnt,branch in enumerate(c.repo_branches.items()):
        <tr class="parity${cnt%2}">
            <td>
                <span class="logtags">
                    <span class="branchtag">${h.link_to(branch[0],
                    h.url('files_home',repo_name=c.repo_name,revision=branch[1].raw_id))}</span>
                </span>
            </td>
            <td><span class="tooltip" title="${h.tooltip(h.age(branch[1].date))}">${h.fmt_date(branch[1].date)}</span></td>
            <td title="${branch[1].author}">${h.person(branch[1].author)}</td>
            <td>
                <div>
                    <pre><a href="${h.url('files_home',repo_name=c.repo_name,revision=branch[1].raw_id)}">r${branch[1].revision}:${h.short_id(branch[1].raw_id)}</a></pre>
                </div>
            </td>
            <td>
                <input class="branch-compare" type="radio" name="compare_org" value="${branch[0]}"/>
                <input class="branch-compare" type="radio" name="compare_other" value="${branch[0]}"/>
            </td>
        </tr>
        %endfor
        % if hasattr(c,'repo_closed_branches') and c.repo_closed_branches:
          %for cnt,branch in enumerate(c.repo_closed_branches.items()):
          <tr class="parity${cnt%2}">
              <td>
                  <span class="logtags">
                      <span class="branchtag">${h.link_to(branch[0]+' [closed]',
                      h.url('changeset_home',repo_name=c.repo_name,revision=branch[1].raw_id))}</span>
                  </span>
              </td>
              <td><span class="tooltip" title="${h.tooltip(h.age(branch[1].date))}">${h.fmt_date(branch[1].date)}</span></td>
              <td title="${branch[1].author}">${h.person(branch[1].author)}</td>
              <td>
                <div>
                    <pre><a href="${h.url('files_home',repo_name=c.repo_name,revision=branch[1].raw_id)}">r${branch[1].revision}:${h.short_id(branch[1].raw_id)}</a></pre>
                </div>
              </td>
              <td></td>
          </tr>
          %endfor
        %endif
    </table>
    </div>
%else:
    ${_('There are no branches yet')}
%endif