Files
@ 260a7a01b054
Branch filter:
Location: kallithea/rhodecode/tests/functional/test_changelog.py
260a7a01b054
5.2 KiB
text/x-python
follow Python conventions for boolean values
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 | from rhodecode.tests import *
class TestChangelogController(TestController):
def test_index_hg(self):
self.log_user()
response = self.app.get(url(controller='changelog', action='index',
repo_name=HG_REPO))
response.mustcontain('''id="chg_20" class="container tablerow1"''')
response.mustcontain(
"""<input class="changeset_range" """
"""id="5e204e7583b9c8e7b93a020bd036564b1e731dae" """
"""name="5e204e7583b9c8e7b93a020bd036564b1e731dae" """
"""type="checkbox" value="1" />"""
)
response.mustcontain(
"""<span class="changeset_hash">r154:5e204e7583b9</span>"""
)
response.mustcontain("""Small update at simplevcs app""")
# response.mustcontain(
# """<div id="changed_total_5e204e7583b9c8e7b93a020bd036564b1e731dae" """
# """style="float:right;" class="changed_total tooltip" """
# """title="Affected number of files, click to show """
# """more details">3</div>"""
# )
def test_index_pagination_hg(self):
self.log_user()
#pagination
self.app.get(url(controller='changelog', action='index',
repo_name=HG_REPO), {'page': 1})
self.app.get(url(controller='changelog', action='index',
repo_name=HG_REPO), {'page': 2})
self.app.get(url(controller='changelog', action='index',
repo_name=HG_REPO), {'page': 3})
self.app.get(url(controller='changelog', action='index',
repo_name=HG_REPO), {'page': 4})
self.app.get(url(controller='changelog', action='index',
repo_name=HG_REPO), {'page': 5})
response = self.app.get(url(controller='changelog', action='index',
repo_name=HG_REPO), {'page': 6})
# Test response after pagination...
response.mustcontain(
"""<input class="changeset_range" """
"""id="46ad32a4f974e45472a898c6b0acb600320579b1" """
"""name="46ad32a4f974e45472a898c6b0acb600320579b1" """
"""type="checkbox" value="1" />"""
)
response.mustcontain(
"""<span class="changeset_hash">r64:46ad32a4f974</span>"""
)
# response.mustcontain(
# """<div id="changed_total_46ad32a4f974e45472a898c6b0acb600320579b1" """
# """style="float:right;" class="changed_total tooltip" """
# """title="Affected number of files, click to show """
# """more details">21</div>"""
# )
#
# response.mustcontain(
# """<a href="/%s/changeset/"""
# """46ad32a4f974e45472a898c6b0acb600320579b1" """
# """title="Merge with 2e6a2bf9356ca56df08807f4ad86d480da72a8f4">"""
# """46ad32a4f974</a>""" % HG_REPO
# )
def test_index_git(self):
self.log_user()
response = self.app.get(url(controller='changelog', action='index',
repo_name=GIT_REPO))
response.mustcontain('''id="chg_20" class="container tablerow1"''')
response.mustcontain(
"""<input class="changeset_range" """
"""id="95f9a91d775b0084b2368ae7779e44931c849c0e" """
"""name="95f9a91d775b0084b2368ae7779e44931c849c0e" """
"""type="checkbox" value="1" />"""
)
response.mustcontain(
"""<span class="changeset_hash">r613:95f9a91d775b</span>"""
)
response.mustcontain("""fixing stupid typo in context for mercurial""")
# response.mustcontain(
# """<div id="changed_total_5e204e7583b9c8e7b93a020bd036564b1e731dae" """
# """style="float:right;" class="changed_total tooltip" """
# """title="Affected number of files, click to show """
# """more details">3</div>"""
# )
def test_index_pagination_git(self):
self.log_user()
#pagination
self.app.get(url(controller='changelog', action='index',
repo_name=GIT_REPO), {'page': 1})
self.app.get(url(controller='changelog', action='index',
repo_name=GIT_REPO), {'page': 2})
self.app.get(url(controller='changelog', action='index',
repo_name=GIT_REPO), {'page': 3})
self.app.get(url(controller='changelog', action='index',
repo_name=GIT_REPO), {'page': 4})
self.app.get(url(controller='changelog', action='index',
repo_name=GIT_REPO), {'page': 5})
response = self.app.get(url(controller='changelog', action='index',
repo_name=GIT_REPO), {'page': 6})
# Test response after pagination...
response.mustcontain(
"""<input class="changeset_range" """
"""id="636ed213f2f11ef91071b9c24f2d5e6bd01a6ed5" """
"""name="636ed213f2f11ef91071b9c24f2d5e6bd01a6ed5" """
"""type="checkbox" value="1" />"""
)
response.mustcontain(
"""<span class="changeset_hash">r515:636ed213f2f1</span>"""
)
|