Files
@ 260a7a01b054
Branch filter:
Location: kallithea/rhodecode/tests/vcs/test_archives.py
260a7a01b054
3.5 KiB
text/x-python
follow Python conventions for boolean values
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 | from __future__ import with_statement
import os
import tarfile
import zipfile
import datetime
import tempfile
import StringIO
from base import BackendTestMixin
from conf import SCM_TESTS
from rhodecode.lib.vcs.exceptions import VCSError
from rhodecode.lib.vcs.nodes import FileNode
from rhodecode.lib.vcs.utils.compat import unittest
class ArchivesTestCaseMixin(BackendTestMixin):
@classmethod
def _get_commits(cls):
start_date = datetime.datetime(2010, 1, 1, 20)
for x in xrange(5):
yield {
'message': 'Commit %d' % x,
'author': 'Joe Doe <joe.doe@example.com>',
'date': start_date + datetime.timedelta(hours=12 * x),
'added': [
FileNode('%d/file_%d.txt' % (x, x),
content='Foobar %d' % x),
],
}
def test_archive_zip(self):
path = tempfile.mkstemp()[1]
with open(path, 'wb') as f:
self.tip.fill_archive(stream=f, kind='zip', prefix='repo')
out = zipfile.ZipFile(path)
for x in xrange(5):
node_path = '%d/file_%d.txt' % (x, x)
decompressed = StringIO.StringIO()
decompressed.write(out.read('repo/' + node_path))
self.assertEqual(
decompressed.getvalue(),
self.tip.get_node(node_path).content)
def test_archive_tgz(self):
path = tempfile.mkstemp()[1]
with open(path, 'wb') as f:
self.tip.fill_archive(stream=f, kind='tgz', prefix='repo')
outdir = tempfile.mkdtemp()
outfile = tarfile.open(path, 'r|gz')
outfile.extractall(outdir)
for x in xrange(5):
node_path = '%d/file_%d.txt' % (x, x)
self.assertEqual(
open(os.path.join(outdir, 'repo/' + node_path)).read(),
self.tip.get_node(node_path).content)
def test_archive_tbz2(self):
path = tempfile.mkstemp()[1]
with open(path, 'w+b') as f:
self.tip.fill_archive(stream=f, kind='tbz2', prefix='repo')
outdir = tempfile.mkdtemp()
outfile = tarfile.open(path, 'r|bz2')
outfile.extractall(outdir)
for x in xrange(5):
node_path = '%d/file_%d.txt' % (x, x)
self.assertEqual(
open(os.path.join(outdir, 'repo/' + node_path)).read(),
self.tip.get_node(node_path).content)
def test_archive_default_stream(self):
tmppath = tempfile.mkstemp()[1]
with open(tmppath, 'w') as stream:
self.tip.fill_archive(stream=stream)
mystream = StringIO.StringIO()
self.tip.fill_archive(stream=mystream)
mystream.seek(0)
with open(tmppath, 'r') as f:
self.assertEqual(f.read(), mystream.read())
def test_archive_wrong_kind(self):
with self.assertRaises(VCSError):
self.tip.fill_archive(kind='wrong kind')
def test_archive_empty_prefix(self):
with self.assertRaises(VCSError):
self.tip.fill_archive(prefix='')
def test_archive_prefix_with_leading_slash(self):
with self.assertRaises(VCSError):
self.tip.fill_archive(prefix='/any')
# For each backend create test case class
for alias in SCM_TESTS:
attrs = {
'backend_alias': alias,
}
cls_name = ''.join(('%s archive test' % alias).title().split())
bases = (ArchivesTestCaseMixin, unittest.TestCase)
globals()[cls_name] = type(cls_name, bases, attrs)
if __name__ == '__main__':
unittest.main()
|