Files
@ ac5d236a995a
Branch filter:
Location: kallithea/docs/index.rst
ac5d236a995a
1.1 KiB
text/prs.fallenstein.rst
tests: improve robustness of notifications tests
The notifications tests make the assumption that there are no notifications
at the start of the test, which is explicitly asserted.
However, any other test, like the one introduced in commit 9a23b444a7fe
(pullrequests: detect invalid reviewers and raise HTTPBadRequest), could add
new notifications to the database, and thus fail these assertions.
Just like the notifications tests already cleaned all notifications at the
end of the test (tearDown), make sure to clean them at the start (setUp)
too.
The notifications tests make the assumption that there are no notifications
at the start of the test, which is explicitly asserted.
However, any other test, like the one introduced in commit 9a23b444a7fe
(pullrequests: detect invalid reviewers and raise HTTPBadRequest), could add
new notifications to the database, and thus fail these assertions.
Just like the notifications tests already cleaned all notifications at the
end of the test (tearDown), make sure to clean them at the start (setUp)
too.