Files
@ b3ef9012be54
Branch filter:
Location: kallithea/MANIFEST.in
b3ef9012be54
1.1 KiB
text/plain
hg: fix continuation binding of callback variables
The get_file_annotate generator yields a callback. That callback happened to
look at the current state of the generator. It happened to work anyway,
apparently because the callback always was called immediately, before the
generator state changed. But for example if the get_file_annotate was buffered
into a list, the callback would return the same result each time.
Instead, bind the generator iterator variables as named parameter values for
the callback function. That will make sure the callback always returns the
right value.
The get_file_annotate generator yields a callback. That callback happened to
look at the current state of the generator. It happened to work anyway,
apparently because the callback always was called immediately, before the
generator state changed. But for example if the get_file_annotate was buffered
into a list, the callback would return the same result each time.
Instead, bind the generator iterator variables as named parameter values for
the callback function. That will make sure the callback always returns the
right value.