Files
@ e63bcce18fef
Branch filter:
Location: kallithea/kallithea/tests/models/test_comments.py
e63bcce18fef
10.0 KiB
text/x-python
py3: automatic migration with 2to3 -f unicode
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 | import pytest
from tg.util.webtest import test_context
from kallithea.model.comment import ChangesetCommentsModel
from kallithea.model.db import Repository
from kallithea.tests import base
class TestComments(base.TestController):
def _check_comment_count(self, repo_id, revision,
expected_len_comments, expected_len_inline_comments,
f_path=None, line_no=None
):
comments = ChangesetCommentsModel().get_comments(repo_id,
revision=revision)
assert len(comments) == expected_len_comments
inline_comments = ChangesetCommentsModel().get_inline_comments(repo_id,
revision=revision, f_path=f_path, line_no=line_no)
assert len(inline_comments) == expected_len_inline_comments
return comments, inline_comments
def test_create_delete_general_comment(self):
with test_context(self.app):
repo_id = Repository.get_by_repo_name(base.HG_REPO).repo_id
revision = '9a7b4ff9e8b40bbda72fc75f162325b9baa45cda'
self._check_comment_count(repo_id, revision,
expected_len_comments=0, expected_len_inline_comments=0)
text = 'a comment'
new_comment = ChangesetCommentsModel().create(
text=text,
repo=base.HG_REPO,
author=base.TEST_USER_REGULAR_LOGIN,
revision=revision,
send_email=False)
self._check_comment_count(repo_id, revision,
expected_len_comments=1, expected_len_inline_comments=0)
ChangesetCommentsModel().delete(new_comment)
self._check_comment_count(repo_id, revision,
expected_len_comments=0, expected_len_inline_comments=0)
def test_create_delete_inline_comment(self):
with test_context(self.app):
repo_id = Repository.get_by_repo_name(base.HG_REPO).repo_id
revision = '9a7b4ff9e8b40bbda72fc75f162325b9baa45cda'
self._check_comment_count(repo_id, revision,
expected_len_comments=0, expected_len_inline_comments=0)
text = 'an inline comment'
f_path = 'vcs/tests/base.py'
line_no = 'n50'
new_comment = ChangesetCommentsModel().create(
text=text,
repo=base.HG_REPO,
author=base.TEST_USER_REGULAR_LOGIN,
revision=revision,
f_path=f_path,
line_no=line_no,
send_email=False)
comments, inline_comments = self._check_comment_count(repo_id, revision,
expected_len_comments=0, expected_len_inline_comments=1)
# inline_comments is a list of tuples (file_path, dict)
# where the dict keys are line numbers and values are lists of comments
assert inline_comments[0][0] == f_path
assert len(inline_comments[0][1]) == 1
assert line_no in inline_comments[0][1]
assert inline_comments[0][1][line_no][0].text == text
ChangesetCommentsModel().delete(new_comment)
self._check_comment_count(repo_id, revision,
expected_len_comments=0, expected_len_inline_comments=0)
def test_create_delete_multiple_inline_comments(self):
with test_context(self.app):
repo_id = Repository.get_by_repo_name(base.HG_REPO).repo_id
revision = '9a7b4ff9e8b40bbda72fc75f162325b9baa45cda'
self._check_comment_count(repo_id, revision,
expected_len_comments=0, expected_len_inline_comments=0)
text = 'an inline comment'
f_path = 'vcs/tests/base.py'
line_no = 'n50'
new_comment = ChangesetCommentsModel().create(
text=text,
repo=base.HG_REPO,
author=base.TEST_USER_REGULAR_LOGIN,
revision=revision,
f_path=f_path,
line_no=line_no,
send_email=False)
text2 = 'another inline comment, same file'
line_no2 = 'o41'
new_comment2 = ChangesetCommentsModel().create(
text=text2,
repo=base.HG_REPO,
author=base.TEST_USER_REGULAR_LOGIN,
revision=revision,
f_path=f_path,
line_no=line_no2,
send_email=False)
text3 = 'another inline comment, same file'
f_path3 = 'vcs/tests/test_hg.py'
line_no3 = 'n159'
new_comment3 = ChangesetCommentsModel().create(
text=text3,
repo=base.HG_REPO,
author=base.TEST_USER_REGULAR_LOGIN,
revision=revision,
f_path=f_path3,
line_no=line_no3,
send_email=False)
comments, inline_comments = self._check_comment_count(repo_id, revision,
expected_len_comments=0, expected_len_inline_comments=2)
# inline_comments is a list of tuples (file_path, dict)
# where the dict keys are line numbers and values are lists of comments
assert inline_comments[0][0] == f_path
assert len(inline_comments[0][1]) == 2
assert inline_comments[0][1][line_no][0].text == text
assert inline_comments[0][1][line_no2][0].text == text2
assert inline_comments[1][0] == f_path3
assert len(inline_comments[1][1]) == 1
assert line_no3 in inline_comments[1][1]
assert inline_comments[1][1][line_no3][0].text == text3
# now delete only one comment
ChangesetCommentsModel().delete(new_comment2)
comments, inline_comments = self._check_comment_count(repo_id, revision,
expected_len_comments=0, expected_len_inline_comments=2)
# inline_comments is a list of tuples (file_path, dict)
# where the dict keys are line numbers and values are lists of comments
assert inline_comments[0][0] == f_path
assert len(inline_comments[0][1]) == 1
assert inline_comments[0][1][line_no][0].text == text
assert inline_comments[1][0] == f_path3
assert len(inline_comments[1][1]) == 1
assert line_no3 in inline_comments[1][1]
assert inline_comments[1][1][line_no3][0].text == text3
# now delete all others
ChangesetCommentsModel().delete(new_comment)
ChangesetCommentsModel().delete(new_comment3)
self._check_comment_count(repo_id, revision,
expected_len_comments=0, expected_len_inline_comments=0)
def test_selective_retrieval_of_inline_comments(self):
with test_context(self.app):
repo_id = Repository.get_by_repo_name(base.HG_REPO).repo_id
revision = '9a7b4ff9e8b40bbda72fc75f162325b9baa45cda'
self._check_comment_count(repo_id, revision,
expected_len_comments=0, expected_len_inline_comments=0)
text = 'an inline comment'
f_path = 'vcs/tests/base.py'
line_no = 'n50'
new_comment = ChangesetCommentsModel().create(
text=text,
repo=base.HG_REPO,
author=base.TEST_USER_REGULAR_LOGIN,
revision=revision,
f_path=f_path,
line_no=line_no,
send_email=False)
text2 = 'another inline comment, same file'
line_no2 = 'o41'
new_comment2 = ChangesetCommentsModel().create(
text=text2,
repo=base.HG_REPO,
author=base.TEST_USER_REGULAR_LOGIN,
revision=revision,
f_path=f_path,
line_no=line_no2,
send_email=False)
text3 = 'another inline comment, same file'
f_path3 = 'vcs/tests/test_hg.py'
line_no3 = 'n159'
new_comment3 = ChangesetCommentsModel().create(
text=text3,
repo=base.HG_REPO,
author=base.TEST_USER_REGULAR_LOGIN,
revision=revision,
f_path=f_path3,
line_no=line_no3,
send_email=False)
# now selectively retrieve comments of one file
comments, inline_comments = self._check_comment_count(repo_id, revision,
f_path=f_path,
expected_len_comments=0, expected_len_inline_comments=1)
# inline_comments is a list of tuples (file_path, dict)
# where the dict keys are line numbers and values are lists of comments
assert inline_comments[0][0] == f_path
assert len(inline_comments[0][1]) == 2
assert inline_comments[0][1][line_no][0].text == text
assert inline_comments[0][1][line_no2][0].text == text2
# now selectively retrieve comments of one file, one line
comments, inline_comments = self._check_comment_count(repo_id, revision,
f_path=f_path, line_no=line_no2,
expected_len_comments=0, expected_len_inline_comments=1)
# inline_comments is a list of tuples (file_path, dict)
# where the dict keys are line numbers and values are lists of comments
assert inline_comments[0][0] == f_path
assert len(inline_comments[0][1]) == 1
assert inline_comments[0][1][line_no2][0].text == text2
# verify that retrieval based on line_no but no f_path fails
with pytest.raises(Exception) as excinfo:
self._check_comment_count(repo_id, revision,
f_path=None, line_no=line_no2,
expected_len_comments=0, expected_len_inline_comments=0)
assert 'line_no only makes sense if f_path is given' in str(excinfo.value)
|