kallithea Files · kallithea/templates/pullrequests/pullrequest_show

Files @ f33cc4af706b

Branch filter:

Location: kallithea/kallithea/templates/pullrequests/pullrequest_show_my.html

f33cc4af706b 1.1 KiB text/html Show Annotation Show as Raw Download as Raw

domruf

tests: finally block also needs to be executed if api_call itself fails

The cleanup code (finally block) should be executed as soon as something what
changes the db fails.

I don't remember which one but one of these tests failed and caused all the
others to fail as well because the database wasn't cleaned up after the first
failure. That made finding the root cause more difficult then it should have
been.

<%inherit file="/base/base.html"/>

<%namespace name="pullrequest_data" file="pullrequest_data.html"/>

<%block name="title">
    ${_('My Pull Requests')}
</%block>

<%def name="breadcrumbs_links()">
    ${_('My Pull Requests')}
</%def>

<%block name="header_menu">
    ${self.menu('my_pullrequests')}
</%block>

<%def name="main()">

<div class="box">
    <!-- box / title -->
    <div class="title">
        ${self.breadcrumbs()}
    </div>

    <div class="normal-indent">
        <div>
        %if c.closed:
            ${h.link_to(_('Hide closed pull requests (only show open pull requests)'), h.url('my_pullrequests'))}
        %else:
            ${h.link_to(_('Show closed pull requests (in addition to open pull requests)'), h.url('my_pullrequests',closed=1))}
        %endif
        </div>
    </div>

    <div class="pullrequests_section_head">${_('Pull Requests Created by Me')}</div>
    ${pullrequest_data.pullrequest_overview(c.my_pull_requests)}

    <div class="pullrequests_section_head" style="clear:both">${_('Pull Requests I Participate In')}</div>
    ${pullrequest_data.pullrequest_overview(c.participate_in_pull_requests)}

</div>
</%def>