MAR-148: Fixed the tests for wsgi_website role:

- Fix issues related to newlines in outputs.
- Refactor Python version check to make it more robust.

MAR-148: Fixed Ansible warnings for wsgi_website role:

- Use the length filter for conditionals that involve lists.

MAR-148: Fixed tests for the preseed role:

- A couple of newline-related fixes (where command output now contains
them as compared to previous versions of Testinfra).
- Update path for the default inventory location.

MAR-148: Fixed tests for the mail_server role:

- Implement small workaround for sieve-connect invocations (due to
special treatment of 255 exit code by Testinfra itself).
- Fixed a couple of newline-related errors coming from command
outputs.

MAR-148: Fixed tests for the backup_server role:

- Fix some handling of newlines by updating test data keys to include
newline at the end of file.
- Ensure we do not produce exit code 255 when testing the available
authentication mechanisms for the backup SSH server
instance (otherwise we get runtime exception from Testinfra itself).
- Fix some handling of newlines by not doing stripping and including
newline in expected output.

MAR-148: Fix test for the common role:

- Do some additional stripping on command outputs to get rid of extra
new lines.

MAR-148: Fix Ansible warnings for the common role:

- Use the length filter for conditionals that require a (parameter)
list to be non-empty.
- Use explicit quoting for the cron task hour/minute.

MAR-148: Refactor handling of GnuPG backup client keyring:

- Don't use the include_tasks, it seems to cause more issues than it
helps (with linting etc).
- Directly reference all the relevant handlers as part of notification
instead.

MAR-148: Fix Ansible warnings for the backup_client role:

- Use length filter to check if optional parameter lists have been
supplied.
- Quote the crontab trigger times to avoid implicit conversion from
integer to string.

MAR-148: Disable Ansible's default of enforcing group names without dashes through Molecule configuration files:

The following links might be a useful read:

- https://github.com/ansible/ansible/issues/56930 (issues relaetd to
lack of docs, but many complaints and explanations within)
- https://groups.google.com/forum/#!topic/ansible-devel/bjAcM9ferIw

MAR-148: Fixing linting errors:

- Do not compare against booleans when value is already boolean in
"when" conditions.
- Do not compare variables to empty strings in "when" conditions. This
change currently works only for complex variables (stuff can break
badly in case of simple variables in current default Ansible
configuration).

MAR-148: Fixing linting errors:

- Do not compare against booleans when value is already boolean in
"when" conditions.
- Use pipefail in conjunction with setting the shell to Bash when
extracting the backup encryption key IDs.
- Do not compare variables to empty strings in "when" conditions. This
change currently works only for complex variables (stuff can break
badly in case of simple variables in current default Ansible
configuration).
- Fix missing space in one of Jinja2 templates.

MAR-148: Drop configuration of retry files location:

- Ansible 2.8.x has switched to not creating the retry files by
default.

MAR-148: Use dynamic include_tasks for cleaning up the GnuPG keyring used for backup encryption and signing:

- Required due to change in Ansible - the import_tasks cannot be
notified any longer by the tasks.

MAR-146: Added separate parameter for Pyhton 3 virtual environment used for upgrade checks:

- Release notes updated to mention the breaking change.
- Updated role reference documentation to cover the new parameter.
- Updated default values for the dedicated Python virtual
environments.
- Update role common to deploy separate requirements for the two
environments.
- Include wheel package in the requirements.

Noticket: Fix the invocation of GnuPG to use the --no-tty option:

- At least in some cases GnuPG would otherwise fail to run.

MAR-141: Fix handling of pipreqcheck virtualenv package installation:

- Deploy all requirements through requirements file, even if using
pip. Improves reproducability of installed packages and solves some
double-versioning issues for packages like pip etc.
- Updated test for validating installed packages.

MAR-138: Updated documentation and release notes:

- Document the new xmpp_prosody_package parameter.
- Add the breaking change informaiton in release notes (although most
likely nothing will be really broken).

MAR-138: Switch to using Prosody stable branch nightlies:

- Introduced additional parameter for specifying name of Prosody
package to install.
- Updated tests.

MAR-134: Updated requirements:

- Remove workaround for broken pytest.
- Updated all requirements.

MAR-134: Fix Ansible warning about use of apt and with_items:

- The apt module can accept list of names already, and with_items is
considered to be deprecated in this regard (otherwise it would
end-up running one apt command per item).
- Changed multiple roles where apt was used together along with_items.

MAR-134: Make sure the Python setuptools are available for virtualenv use:

- Must be present for pipreqcheck virtual environments to get setup
correctly.
- Should be a good idea to include it in the default web server config
too.

MAR-135: Updated documentation related to new environment variable for running handlers explicitly:

- Updated the usage instructions.
- Updated the release notes to include mention of breaking change.

MAR-135: Switch to using run_handlers instead of handlers as variable:

- Updated all roles to now depend on run_handlers being set to True in
order to force execution of handlers.

MAR-132: Updated test site instructions:

- Mention that either Jessie or Stretch can be used for installation.
- Updated command for getting the SSH key fingerprints to use the dig
tool.

MAR-132: Updated usage instructions for Debian Stretch:

- Switch to Debian Stretch for showing role usage.
- Updated TBG deployment to use the latest version.
- Fixed a bunch of sample task definitions to use full expanded (YAML)
syntax.
- Updated commands used for backup client/server (invocation of GnuPG).

MAR-132: Fix the handler that recreates the GnuPG keyring for duplicity:

- In Debian Stretch it can happen that a file (the GnuPG Unix socket)
dissappears in middle of removing the directory, causing
failures. Switch to using the "rm" command instead.

MAR-132: Pin packages as part of wsgi_website role test to ensure reproducability:

- Provide explicit list of packages being deployed. This should ensure
we can always reproduce the tests without being affected by new
releases of packages.
- Updated expected requirements in test for the jedi version.

MAR-132: Fix PHP timezone test for Debian Stretch in web_server role:

- Read the timezone from server instead of depending on fixed value.

MAR-132: Update documentation for backup_server role:

- Mention that DSA key is required only on Debian Jessie.
- Remove unused parameter from role defaults.

MAR-132: Added support for Debian 9 (Stretch) to backup_server role:

- Deploy slightly different sshd_config file for Stretch (DSA key
unused).
- Updated Molecule tests to cover testing on Debian 9.
- Updated role reference documentation.

MAR-132: Added support for Debian 9 (Stretch) to database role:

- Updated Molecule test configuration to include Debian 9 Stretch.
- Updated documentation.

MAR-132: Added support for Debian 9 (Stretch) to database_server role:

- Updated Molecule test configuration to include Debian 9 Stretch in
test matrix.
- Updated tests related to UTF-8 configuration (differences between
Debian 8 and 9).
- Deploy UTF-8 configuration in alternate locations depending on what
distro is being used.
- Force set-up of root password on Debian Stretch (default is to use
the unix_socket authentication).

MAR-132: Workarounds for wsgi_website Python virtual environment in Debian Stretch:

- Manually install setuptools in Python virtual environment on Debian
Stretch, otherwise the pkg-resources==0.0.0 package will mess with
pip freeze etc.
- Add back installation of futures package, even on Python 3 (since it
does not cause any harm).
- A small cleanup of how requirements are treated will be done in
separate ticket.

MAR-132: Added support for Debian 9 (Stretch) to wsgi_website role:

- Set the shell for application system account explicitly (workaround
for Debian bug 865762 in Stretch).
- Updated Molecule tests to cover Debian 9.
- Updated Molecule test preparation playbook to account for a number
of differences between Jessie and Stretch (mainly related to mailing
functionality).
- Renamed a couple of variables in test for sending out mails to make
it clearer what is being looked up as part of regex matching.
- Updated Molecule tests where certain paths depend on what Debian
release they are ran against.
- Split-up Jessie-specific tests into separate file.
- Remove the /bin/ss utility instead of renaming it (testinfra socket
tests do not work with /bin/ss).

MAR-132: Fix virtual environment set-up in wsgi_website role:

- Install more up-to-date version of pip. This fixes some issues
related to pip freeze detecting argparse and wsgiref in virtualenv
as separate packages.
- Remove the pkg-resources package from virtualenv. Workaround for
Debian-specific behaviour. More details at:
- https://github.com/pypa/pip/issues/4022
- https://bugs.launchpad.net/ubuntu/+source/python-pip/+bug/1635463
- https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=871790
- Deploy Gunicorn requirements file without switching to website admin
user (otherwise Ansible fails to template the file due to
permissions restrictions).
- Updated test for checking packages installed in the virtualenv.

MAR-132: Added support for Debian 9 (Stretch) to php_website role:

- Implemented the necessary changes related to differences between PHP
versions and related paths (PHP 5 vs PHP 7).
- Set the shell for application system account explicitly (workaround
for Debian bug 865762 in Stretch).
- Updated Molecule tests to cover Debian 9.
- Updated Molecule test preparation playbook to account for a number
of differences between Jessie and Stretch (mainly related to mailing
functionality).
- Use more specific host groups in tests.
- Renamed a couple of variables in test for sending out mails to make
it clearer what is being looked up as part of regex matching.
- Updated Molecule tests where certain paths depend on what Debian
release they are ran against.
- Split-up Jessie-specific tests into separate file.

MAR-132: Added support for Debian 9 (Stretch) to web_server role:

- Introduced internal parameters for controlling differing package
names, service names, and paths for PHP FPM package.
- Added Debian 9 machines to Molecule configuration, including the
client machine.
- Restructured slightly preparaiton playbook to support both Jessie
and Stretch.
- Added custom pytest fixture for having a better way to determine
expected package names etc related to PHP.
- Created copy of private key/certificate pair used for testing of
mandatory parameters (to be used with Stretch machine).
- Fixed invalid specification for hosts on top of which the
connectivity test should be run.
- Updated a couple of task names (avoiding to reference PHP 5).
- Updated documentation.

MAR-132: Added support for Debian 9 (Stretch) to mail_server role:

- Updated Molecule configuration to include set-up of additional
instances for testing.
- Updated configuration for test instances.
- Use separate clients in testing of Jessie/Stretch instances.
- Duplicate private keys/certificates for testing of mandatory
parameters on Debian 9.
- Refactored testing of mail deliveries (via swaks) to use
test-generated message ID - improves reliability and solves some
incompatibilities between swaks version in Jessie and Stretch.
- Updated tests for TLS testing to take into account newer OpenSSL
error/output messages. A bit of an ugly hack at the moment, but
beats duplicating tests for now.

MAR-132: Fixed creation of test LDAP entries mail_server role tests:

- Do not use the ldap_entries option of the ldap_server role.
- Invoke the ldap_entry and ldap_attr modules directly.

MAR-132: Added support to xmpp_server role for Debian 9 (Stretch):

- Updated tests to include Debian 9 in testing. Existing private keys
are reused where possible (since most of the naming is identical
between the machines with jessie/stretch).
- Updated invocation of sendxmpp in tests as workaround for
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=854210.
- Updated testing of imported keys to accomodate differences between
gpg/gpg2 (used by apt-key in Jessie/Stretch).

MAR-132: LDAP-related fixes to xmpp_server role tests:

- Do not create LDAP accounts through the ldap_entries parameter of
ldap_server, use the ldap_entry and ldap_attr modules directly.

MAR-132: Add support for Debian 9 (Stretch) to ldap_server role:

- Updated Molecule tests to cover Debian 9 as well.
- Remove the ss utility instead of renaming it when preparing for
tests, and make sure the netstat utility is available.
- Duplicate private key/certificate for mandatory parameters testing.

MAR-132: Parametrise tests in ldap_server role:

- Dynamically obtain inventory hostnames (don't hard-code them).
- Parametrise connectivity test, switching to using inventory
hostnames along the way (instead of hard-coded IPs in tests.
- Populate /etc/hosts with inventory hostnames in client machine (used
for connectivity tests).

MAR-131: Use Python 3 in test site wsgihello2 role:

- Switch role to use Python 3 via meta dependency.
- Fix the demo application to work with Python 3.
- Update ipcalc dependency (so it would work with Python 3).