majic-ansible-roles Changeset

Changeset - b34547147a36

Parent rev.

Child rev.

[Not reviewed]

0 1 0

Branko Majic (branko) - 9 months ago 2024-02-10 11:10:11
branko@majic.rs

MAR-193: Fix some linting errors reported by shellcheck.

1 file changed with 5 insertions and 4 deletions:

roles/common/files/pip_check_requirements_upgrades.sh

0 comments (0 inline, 0 general)

roles/common/files/pip_check_requirements_upgrades.sh

➞

Show inline comments

@@ @@ -104,7 +104,7 @@ EOF @@
 # Set-up colours for message printing if we're not piping and terminal is
 # capable of outputting the colors.
 _color_terminal=$(tput colors 2>&1)
-if [[ -t 1 ]] && (( ${_color_terminal} > 0 )); then
 if [[ -t 1 ]] && (( _color_terminal > 0 )); then
     _text_bold=$(tput bold)
     _text_white=$(tput setaf 7)
     _text_blue=$(tput setaf 6)
@@ @@ -179,7 +179,7 @@ while getopts "V:qdvh" opt; do @@
     esac
 done
 i=$OPTIND
-shift $(($i-1))
+shift $(( i-1 ))
 if [[ ${#@} == 0 ]]; then
 fi
 # Activate the virtual environment if it was specified.
 # shellcheck disable=SC1090 # no point in validating external script
 [[ -n $virtualenv ]] && source "$virtualenv/bin/activate"
 # Verify pip-compile is available.
@@ @@ -271,8 +272,8 @@ for environment in "$config_dir"/*; do @@
         # versioning information.
         new=$(echo "$new" | sed -e 's/[[:blank:]]*#.*//' | grep -v "^$" | sort -u)
         debug "Current requirements:\n$(echo "$current")"
         debug "New requirements:\n$(echo "$new")"
         debug "Current requirements:\n$current\n"
         debug "New requirements:\n$new\n"
         # Run diff, storing the output and result.
         # This is using Bash process substitution, which helps avoid

0 comments (0 inline, 0 general)