MAR-148: Improve the SSH connectivity tests in backup_server role to be more reliable:

- Introduce a session-level fixture for setting permissions for client
SSH private keys (fixes errors related to SSH requesting tighter
permissions).
- Add assertions for the tests that verify the backup clients cannot
connect to the regular SSH server in case the SSH private keys do
not have correct permissions (just in case).

MAR-148: Clean-up TODO entries for the common role coming from bugs in earlier versions of software:

- Switch to using the systemd task for reloads.
- Add back validation of pipreqcheck activation script file
permissions.
- Add back validation of missing ntp/ntpdate packages.

MAR-148: Added workaround for mysql_user module when using check_implicit_admin parameter

For details see:

- https://github.com/ansible/ansible/commit/47aea84924
- https://github.com/ansible/ansible/issues/64560

MAR-148: Fixed the tests for wsgi_website role:

- Fix issues related to newlines in outputs.
- Refactor Python version check to make it more robust.

MAR-148: Fixed Ansible warnings for wsgi_website role:

- Use the length filter for conditionals that involve lists.

MAR-148: Fixed tests for the preseed role:

- A couple of newline-related fixes (where command output now contains
them as compared to previous versions of Testinfra).
- Update path for the default inventory location.

MAR-148: Fixed tests for the mail_server role:

- Implement small workaround for sieve-connect invocations (due to
special treatment of 255 exit code by Testinfra itself).
- Fixed a couple of newline-related errors coming from command
outputs.

MAR-148: Fixed tests for the backup_server role:

- Fix some handling of newlines by updating test data keys to include
newline at the end of file.
- Ensure we do not produce exit code 255 when testing the available
authentication mechanisms for the backup SSH server
instance (otherwise we get runtime exception from Testinfra itself).
- Fix some handling of newlines by not doing stripping and including
newline in expected output.

MAR-148: Fix test for the common role:

- Do some additional stripping on command outputs to get rid of extra
new lines.

MAR-148: Fix Ansible warnings for the common role:

- Use the length filter for conditionals that require a (parameter)
list to be non-empty.
- Use explicit quoting for the cron task hour/minute.

MAR-148: Refactor handling of GnuPG backup client keyring:

- Don't use the include_tasks, it seems to cause more issues than it
helps (with linting etc).
- Directly reference all the relevant handlers as part of notification
instead.

MAR-148: Fix Ansible warnings for the backup_client role:

- Use length filter to check if optional parameter lists have been
supplied.
- Quote the crontab trigger times to avoid implicit conversion from
integer to string.

MAR-148: Disable Ansible's default of enforcing group names without dashes through Molecule configuration files:

The following links might be a useful read:

- https://github.com/ansible/ansible/issues/56930 (issues relaetd to
lack of docs, but many complaints and explanations within)
- https://groups.google.com/forum/#!topic/ansible-devel/bjAcM9ferIw

MAR-148: Fixing linting errors:

- Do not compare against booleans when value is already boolean in
"when" conditions.
- Do not compare variables to empty strings in "when" conditions. This
change currently works only for complex variables (stuff can break
badly in case of simple variables in current default Ansible
configuration).

MAR-148: Fixing linting errors:

- Do not compare against booleans when value is already boolean in
"when" conditions.
- Use pipefail in conjunction with setting the shell to Bash when
extracting the backup encryption key IDs.
- Do not compare variables to empty strings in "when" conditions. This
change currently works only for complex variables (stuff can break
badly in case of simple variables in current default Ansible
configuration).
- Fix missing space in one of Jinja2 templates.

MAR-148: Drop configuration of retry files location:

- Ansible 2.8.x has switched to not creating the retry files by
default.

MAR-148: Use dynamic include_tasks for cleaning up the GnuPG keyring used for backup encryption and signing:

- Required due to change in Ansible - the import_tasks cannot be
notified any longer by the tasks.

MAR-146: Added separate parameter for Pyhton 3 virtual environment used for upgrade checks:

- Release notes updated to mention the breaking change.
- Updated role reference documentation to cover the new parameter.
- Updated default values for the dedicated Python virtual
environments.
- Update role common to deploy separate requirements for the two
environments.
- Include wheel package in the requirements.

Noticket: Fix the invocation of GnuPG to use the --no-tty option:

- At least in some cases GnuPG would otherwise fail to run.

Noticket: Fix the invocation of GnuPG to use the --no-tty option:

- At least in some cases GnuPG would otherwise fail to run.

MAR-141: Fix handling of pipreqcheck virtualenv package installation:

- Deploy all requirements through requirements file, even if using
pip. Improves reproducability of installed packages and solves some
double-versioning issues for packages like pip etc.
- Updated test for validating installed packages.

MAR-140: Updated developement requirements:

- Fixed to more specific versions due to older release needs.

MAR-139: Updated documentation and release notes:

- Document the new xmpp_prosody_package parameter.
- Add the breaking change informaiton in release notes (although most
likely nothing will be really broken).

MAR-139: Switch to using Prosody stable branch nightlies:

- Introduced additional parameter for specifying name of Prosody
package to install.
- Updated tests.

MAR-138: Updated documentation and release notes:

- Document the new xmpp_prosody_package parameter.
- Add the breaking change informaiton in release notes (although most
likely nothing will be really broken).

MAR-138: Switch to using Prosody stable branch nightlies:

- Introduced additional parameter for specifying name of Prosody
package to install.
- Updated tests.

MAR-134: Updated requirements:

- Remove workaround for broken pytest.
- Updated all requirements.

MAR-134: Fix Ansible warning about use of apt and with_items:

- The apt module can accept list of names already, and with_items is
considered to be deprecated in this regard (otherwise it would
end-up running one apt command per item).
- Changed multiple roles where apt was used together along with_items.

MAR-134: Make sure the Python setuptools are available for virtualenv use:

- Must be present for pipreqcheck virtual environments to get setup
correctly.
- Should be a good idea to include it in the default web server config
too.

MAR-135: Updated documentation related to new environment variable for running handlers explicitly:

- Updated the usage instructions.
- Updated the release notes to include mention of breaking change.

MAR-135: Switch to using run_handlers instead of handlers as variable:

- Updated all roles to now depend on run_handlers being set to True in
order to force execution of handlers.

MAR-132: Updated test site instructions:

- Mention that either Jessie or Stretch can be used for installation.
- Updated command for getting the SSH key fingerprints to use the dig
tool.

MAR-132: Updated usage instructions for Debian Stretch:

- Switch to Debian Stretch for showing role usage.
- Updated TBG deployment to use the latest version.
- Fixed a bunch of sample task definitions to use full expanded (YAML)
syntax.
- Updated commands used for backup client/server (invocation of GnuPG).

MAR-132: Fix the handler that recreates the GnuPG keyring for duplicity:

- In Debian Stretch it can happen that a file (the GnuPG Unix socket)
dissappears in middle of removing the directory, causing
failures. Switch to using the "rm" command instead.

MAR-132: Pin packages as part of wsgi_website role test to ensure reproducability:

- Provide explicit list of packages being deployed. This should ensure
we can always reproduce the tests without being affected by new
releases of packages.
- Updated expected requirements in test for the jedi version.

MAR-132: Fix PHP timezone test for Debian Stretch in web_server role:

- Read the timezone from server instead of depending on fixed value.

MAR-132: Update documentation for backup_server role:

- Mention that DSA key is required only on Debian Jessie.
- Remove unused parameter from role defaults.